-
Notifications
You must be signed in to change notification settings - Fork 380
Support for fs.FS (for embedded files, ideally) and module support#171
Open
jbuchbinder wants to merge 2 commits intofogleman:master from
Open
Support for fs.FS (for embedded files, ideally) and module support #171jbuchbinder wants to merge 2 commits intofogleman:master from
jbuchbinder wants to merge 2 commits intofogleman:master from
Conversation
harrisonhjones
commented
Sep 27, 2022
@fogleman I'm particularly interested in this PR. Do you want/need any help reviewing it? Are you looking for contributors/admins to help you manage this package?
f1mishutka
f1mishutka
approved these changes
Feb 1, 2023
sbinet
commented
May 4, 2023
FYI, I have added something along these lines in "my" fork of gg:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line #170 within LoadFontFace there is an error, it uses fS.Open() in a block where fS has a nil value. It appears to me the developer actually meant to check for fS == nil on the previous if statement for that to hold true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for fs.FS filesystems (which are used for go:embed directives, etc) as well as go module support.