This repository was archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Comments
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
This reverts commit 6d3b2a1.
Codecov Report
@@ Coverage Diff @@ ## master #264 +/- ## ========================================== + Coverage 63.01% 63.03% +0.02% ========================================== Files 142 142 Lines 8968 8973 +5 ========================================== + Hits 5651 5656 +5 Misses 2796 2796 Partials 521 521
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@pingsutw
pingsutw
changed the title
(削除) Remove sys_ptrace dependency (削除ここまで)
(追記) [WIP] Remove sys_ptrace dependency (追記ここまで)
May 13, 2022
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw
pingsutw
changed the title
(削除) [WIP] Remove sys_ptrace dependency (削除ここまで)
(追記) Remove sys_ptrace dependency (追記ここまで)
May 18, 2022
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
TL;DR
Declare the task as a failure when the raw container is failing, and the tasks succeed if both the raw and the sidecar containers succeed
The reason is that sidecar run forever if the raw container fails because the sidecar container keeps waiting for the raw container to write the
SUCCESSfile to the local disk. As a result, the task status was always "running".Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#2162
Follow-up issue
NA