Skip to content

This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Comments

Add support for architecture#294

Open

akhurana001 wants to merge 1 commit intoLyft-Flyte from

Open

Add support for architecture #294
akhurana001 wants to merge 1 commit intoLyft-Flyte from
bump-idl

Conversation

Copy link

@akhurana001 akhurana001 commented Nov 17, 2021

Bump up flyteidl to add support for architecture for container/images : Ref: flyteorg/flyte#1539


 Add support for architecture

f85ae7e

@akhurana001 akhurana001 requested review from EngHabu, anandswaminathan, katrogan, kumare3 and wild-endeavor as code owners

November 17, 2021 19:34

Copy link

welcome bot commented Nov 17, 2021

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
Sign off your commits (Reference: DCO Guide).

Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #294 (f85ae7e) into Lyft-Flyte (9cc1057) will decrease coverage by 6.05%.
The diff coverage is 53.41%.

Impacted file tree graph

@@ Coverage Diff @@
## Lyft-Flyte #294 +/- ##
==============================================
- Coverage 63.19% 57.14% -6.06% 
==============================================
 Files 101 135 +34 
 Lines 7488 10136 +2648 
==============================================
+ Hits 4732 5792 +1060 
- Misses 2208 3697 +1489 
- Partials 548 647 +99

Flag	Coverage Δ
unittests	`55.94% <52.60%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
auth/auth_context.go	`0.00% <0.00%> (ø)`
auth/config/third_party_config.go	`0.00% <0.00%> (ø)`
auth/identity_context.go	`0.00% <0.00%> (ø)`
auth/init_secrets.go	`0.00% <0.00%> (ø)`
auth/token.go	`0.00% <0.00%> (ø)`
auth/user_info_provider.go	`0.00% <0.00%> (ø)`
pkg/async/notifications/email.go	`100.00% <ø> (ø)`
...async/notifications/implementations/aws_emailer.go	`100.00% <ø> (ø)`
...otifications/implementations/noop_notifications.go	`0.00% <0.00%> (ø)`
...g/async/notifications/implementations/publisher.go	`100.00% <ø> (ø)`
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33b902c...f85ae7e. Read the comment docs.

Copy link

Contributor

katrogan commented Nov 17, 2021

hey @akhurana001 just merged https://github.com/flyteorg/flyteadmin/pull/290/files which should include your idl release

Copy link

Contributor

katrogan commented Nov 17, 2021

oh j/k this isn't against master 😅

Copy link

Author

akhurana001 commented Nov 17, 2021

oh j/k this isn't against master 😅

yeah, still on a fork :( ...not sure what's going on with the test-coverage here 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@akhurana001 @katrogan