-
Notifications
You must be signed in to change notification settings - Fork 329
[cq] Untrack .idea/codeStyles/Project.xml #8493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains local code style settings and should not be tracked in the repository. It has been added to .gitignore to prevent future commits.
I was expecting a .gitignore update here?
If we aren't tracking code style, should we have instructions for setting up team settings in the CONTRIBUTING docs?
I was expecting a
.gitignoreupdate here?
It was still cached by git before the .gitignore change in this commit: 8435754
If we aren't tracking code style, should we have instructions for setting up team settings in the
CONTRIBUTINGdocs?
Yes, I am happy to modify it, were there other recommendations other than the wild cards, I cannot remember.
Ah... I'm still confused by the PR title.
[cq] Untrack .idea/codeStyles/Project.xml #8493
This doesn't seem to be doing that?
If we aren't tracking code style, should we have instructions for setting up team settings in the
CONTRIBUTINGdocs?Yes, I am happy to modify it, were there other recommendations other than the wild cards, I cannot remember.
Great question. That's the one that jumps out at me. @helin24 may recall more.
Here's a good place for a continued conversation: #8098
It seems like we should track these in this repository? https://stackoverflow.com/questions/50618188/what-is-codestyleconfig-xml-file-in-codestyles-of-idea-folder
Unless this is causing problems during individual setup.
I don't remember style rules we wanted other than the star imports
This file contains local code style settings and should not be tracked in the repository. It has been added to
.gitignoreto prevent future commits.