This repository was archived by the owner on Jul 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 175
Fixed a bug that would cause multiple instreams to fail#231
Open
simpleTechs wants to merge 2 commits into
Open
Fixed a bug that would cause multiple instreams to fail #231simpleTechs wants to merge 2 commits into
simpleTechs wants to merge 2 commits into
Conversation
When the event handler is removed on stop, it is not correctly re-added on start (only if _timer was not set at all). This causes multiple inStreams to fail, i.e. the first one would play just fine, but after that the time would never execute the "onTimer" method; thus no other inStream would ever play.
danrossi
commented
Jun 7, 2014
Contributor
Good catch the timer needs to be cleared so it can setup a new one. It was done to fix memory leak fixes with the playlist and other events and might have caused issues elsewhere. I would leave that code as it is and just do _timer = null; start will setup a new timer.
As per danrossi's requests, this re-introduces cleaning up the timer in stop and actually set's it to `null`, so that it's recreated in `start()`, with the appropriate event handler set up.
simpleTechs
commented
Jun 7, 2014
Author
You are totally right, I did think of it but had no idea on how to fix it easily. But setting it to null will of course solve this problem :-)
danrossi
commented
Jun 8, 2014
Contributor
i'll push a fix into a merged branch ive made with other fixes.
danrossi
added a commit
that referenced
this pull request
Jun 9, 2014
danrossi
added a commit
that referenced
this pull request
Jun 9, 2014
danrossi
commented
Jun 9, 2014
Contributor
#233 created one here in this branch https://github.com/flowplayer/flash/tree/danielr-231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the event handler is removed on stop, it is not correctly re-added on start (only if _timer was not set at all).
This causes multiple inStreams to fail, i.e. the first one would play just fine, but after that the time would never execute the "onTimer" method; thus no other inStream would ever play.