-
Notifications
You must be signed in to change notification settings - Fork 175
Conversation
...ymous progressbar rendering function in controls plugin gets garbage collected.
danrossi
commented
Mar 13, 2014
This problem arose from some memory leak fixes when making such calls, it's in a different pull request already take a look at the danielr-197 branch.
Just-MadDEN
commented
Mar 13, 2014
Yep, danielr-197's variant looks better. Could you also comment the second commit?
danrossi
commented
Mar 13, 2014
Right. I had gone through all events in an attempt to cleanup any memory issues, I did notice making some of them weak would get garbage collected too early. With that one there was noway to stop the event listener so made it weak. Is it being cleaned up too early and affecting animations ?
danrossi
commented
Mar 13, 2014
Let me know how it's being affected and I'll what I can do. It looks like complete callback and update events.
Just-MadDEN
commented
Mar 13, 2014
Yes, update callback cleaned to early. The progress bar in scrubber stops when the scrubber stays displayed for some time. It looks like the problem is that the progress bar update callback is an anonymous function, so, it gets cleaned too early.
danrossi
commented
Mar 13, 2014
OK taking this back and let the GC deal with it.
danrossi
commented
Mar 13, 2014
#216 it's within this branch for now.
danrossi
commented
Mar 19, 2014
They both should be merged soon thanks it is an issue people are picking up ;(
When PlayListController is in WaitingState and we are trying to play a clip via javascript like:
WaitingState.stop method is called, so execution context waits for infinite recursion to stop.
I can't say if this method was needed for some purposes, because I could not find change history in google code. At least, I did not find any direct calls to this method in code. So, I left it empty.