Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

cleanup API of AffineTransform #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelknoch wants to merge 1 commit into master
base: master
Choose a base branch
Loading
from cleanup-transform-api

Conversation

@michaelknoch
Copy link
Member

@michaelknoch michaelknoch commented Aug 7, 2024

Type of change: cleanup

Motivation (current vs expected behavior)

Based on the conversations in #395 (comment)

Please check if the PR fulfills these requirements

  • Self-review: I am confident this is the simplest and clearest way to achieve the expected behaviour
  • There are no dependencies on other PRs or I have linked dependencies through Zenhub
  • The commit messages are clean and understandable
  • Tests for the changes have been added (for bug fixes / features)

Copy link
Member

@ephemer ephemer left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michaelknoch, I am approving this because in a sense I do consider it an improvement (assuming that the type we're actually intending to vend is CGAffineTransform and not AffineTransform, which I'm pretty sure is the case).

While reviewing this PR though I can see that there would still be quite a bit of cleanup to do in order to "do it properly", i.e. actually renaming AffineTransform to CGAffineTransform to remove the unused type, removing the other initializers that don't exist in CGAffineTransform (like rotationByDegrees), and moving the initializers that are currently in the CGAffineTransform.swift extension into the type itself (and removing their AffineTransform aliases, e.g. scaleByX... as well).

The above doesn't really need to happen before merging this, again assuming that CGAffineTransform is the type we actually intend to vend here. But to "do it properly" there would still be some work here to be done.

I can see that I made CGAffineTransform.swift in May 2017, and from memory I also started working on this project – at least full time – in May 2017 too. So this must be some of the earliest code in the project 😵

michaelknoch reacted with eyes emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ephemer ephemer ephemer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /