-
-
Notifications
You must be signed in to change notification settings - Fork 345
Open
Conversation
Added 'loadend' event listener to xhr. Why is this needed? Appears that in Firefox ver 109.0.1 xhr does not always fire event 'load'. But does fire 'loadend'. Problem was discovered while debugging old Angular 1 application. It is not reproducible in plain playground environment.
Member
Probably because we are not handling other events such as abort. Anyways, we can not do that as uploadNextChunk will be called twice (after load and loadend) and it will be uploading 2x more chunks than it should after each chunk
aayusharyan
commented
Aug 17, 2023
Collaborator
So, if this is not an issue in Vanilla Playground, then that means some issue with Angular integration of this package. 🤔
olavivaino
commented
Aug 17, 2023
Author
Yes, uploadNextChunk will be called twice (unless FF is used), what kind of problems can this cause? I tested single and multiple file uploads and didn't notice anything obviously wrong.
Perhaps better fix would be to trigger only "loadend" and not "load".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'loadend' event listener to xhr.
Why is this needed?
Appears that in Firefox ver 109.0.1 xhr does not always fire event 'load'. But does fire 'loadend'. Problem was discovered while debugging old Angular 1 application. It is not reproducible in plain playground environment.