-
-
Notifications
You must be signed in to change notification settings - Fork 82
Open
Conversation
floatpanebot
floatpanebot
previously requested changes
Sep 7, 2026
@floatpanebot
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @volard! Please fix the following issues with your PR:
- Title: Is too long (57 characters). The PR title must be strictly under 40 characters.
@floatpanebot
floatpanebot
added
ci
CI / build pipeline
area/docs
Docs site / README
documentation
Documentation changes
size/M
Diff: 51–200 lines
labels
Sep 7, 2026
floatpanebot
commented
Sep 7, 2026
Member
Benchmark report — no significant change
Metrics worse: 0 · better: 0 (threshold: ±3%).
benchstat output
goos: linux
goarch: amd64
pkg: github.com/floatpane/matcha/backend
cpu: AMD EPYC 7763 64-Core Processor
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
ParseSearchQuery_Simple-4 3.004μ ± 35% 3.111μ ± 149% ~ (p=0.818 n=6)
ParseSearchQuery_Complex-4 7.322μ ± 28% 7.947μ ± 32% ~ (p=0.699 n=6)
TokenizeSearchQuery-4 4.577μ ± 26% 4.437μ ± 20% ~ (p=0.937 n=6)
geomean 4.652μ 4.787μ +2.90%
│ old.txt │ new.txt │
│ B/op │ B/op vs base │
ParseSearchQuery_Simple-4 26.00 ± 0% 26.00 ± 0% ~ (p=1.000 n=6) 1
ParseSearchQuery_Complex-4 762.0 ± 0% 762.0 ± 0% ~ (p=1.000 n=6) 1
TokenizeSearchQuery-4 176.0 ± 0% 176.0 ± 0% ~ (p=1.000 n=6) 1
geomean 151.6 151.6 +0.00%
1 all samples are equal
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
ParseSearchQuery_Simple-4 2.000 ± 0% 2.000 ± 0% ~ (p=1.000 n=6) 1
ParseSearchQuery_Complex-4 23.00 ± 0% 23.00 ± 0% ~ (p=1.000 n=6) 1
TokenizeSearchQuery-4 9.000 ± 0% 9.000 ± 0% ~ (p=1.000 n=6) 1
geomean 7.453 7.453 +0.00%
1 all samples are equal
pkg: github.com/floatpane/matcha/tui
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
LogPanelView-4 180.0μ ± 10% 162.4μ ± 9% ~ (p=0.065 n=6)
SearchOverlayView-4 177.6μ ± 25% 189.1μ ± 24% ~ (p=0.699 n=6)
InboxConstruction-4 949.4μ ± 11% 1037.5μ ± 12% ~ (p=0.180 n=6)
geomean 311.9μ 317.0μ +1.64%
│ old.txt │ new.txt │
│ B/op │ B/op vs base │
LogPanelView-4 44.67Ki ± 51% 33.23Ki ± 34% ~ (p=0.545 n=6)
SearchOverlayView-4 56.14Ki ± 41% 56.14Ki ± 41% ~ (p=0.355 n=6)
InboxConstruction-4 874.2Ki ± 0% 874.3Ki ± 0% ~ (p=0.145 n=6)
geomean 129.9Ki 117.7Ki -9.39%
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
LogPanelView-4 714.0 ± 0% 713.0 ± 0% ~ (p=0.545 n=6)
SearchOverlayView-4 926.0 ± 0% 926.0 ± 0% ~ (p=0.636 n=6)
InboxConstruction-4 3.478k ± 0% 3.478k ± 0% ~ (p=0.253 n=6)
geomean 1.320k 1.319k -0.04%
auto-generated by benchmarks.yml
@volard
volard
changed the title
(削除) docs: add screenshots for each main view to the docs site (削除ここまで)
(追記) docs: add views screenshots to the docs site (追記ここまで)
Sep 7, 2026
floatpanebot
floatpanebot
previously requested changes
Sep 7, 2026
@floatpanebot
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @volard! Please fix the following issues with your PR:
- Title: Is too long (44 characters). The PR title must be strictly under 40 characters.
@volard
volard
changed the title
(削除) docs: add views screenshots to the docs site (削除ここまで)
(追記) docs: add screenshots to the docs site (追記ここまで)
Sep 7, 2026
floatpanebot
dismissed stale reviews from themself
September 7, 2026 19:26
Formatting issues have been resolved. Thank you!
volard
commented
Sep 7, 2026
Author
@andrinoff should I fix security related things right here or make another branch and stack that one? I just don't think it's relatable to the issue topic, but I'm not sure anyway
andrinoff
commented
Sep 10, 2026
Member
this should be a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
docs/already existed screenshots fromscreenshots/Why?