Skip to content

Navigation Menu

Sign in
Sign up

Add [Tools] Pocket Chords for Guitar App - #1133

Open
rvonsch wants to merge 10 commits into
flipperdevices:main from
rvonsch:rvonsch/pocket_chords_0.1
Open

Add [Tools] Pocket Chords for Guitar App #1133
rvonsch wants to merge 10 commits into
flipperdevices:main from
rvonsch:rvonsch/pocket_chords_0.1

Conversation

@rvonsch

@rvonsch rvonsch commented Jul 14, 2026
edited by xMasterX
Loading

Copy link
Copy Markdown

Application Submission

  • A guitar chord reference diagram app

Extra Requirements

  • n/a

Author Checklist (Fill this out)

  • I've read the contribution guidelines and my PR follows them
  • I own the code I'm submitting or have code owner's permission to submit it
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

AI usage disclosure (Fill this out):

  • Partially AI assisted (clarify below which code was AI assisted and briefly explain what it does).
    Most of the C syntax was ran through Grok to improve functionality though very simple.

  • Fully AI generated (explain what all the generated code does in moderate detail).

  • [ Describe how AI was used in this PR if it was used ]

Reviewer Checklist (Don't fill this out!)

  • Bundle is valid
  • There are no obvious issues with the source code
  • I've ran this application and verified its functionality

@rvonsch rvonsch changed the title (削除) Original submission (削除ここまで) (追記) Add [Tools] Pocket Chords App (追記ここまで) Jul 16, 2026
@rvonsch rvonsch changed the title (削除) Add [Tools] Pocket Chords App (削除ここまで) (追記) Add [Tools] Pocket Chords for Guitar App (追記ここまで) Jul 16, 2026

@xMasterX xMasterX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looks like you forgot to update commit sha, it was pointing to one without readme file, I did update for you.
But the validator fails on the screenshots: Screenshot screenshots/ss0.png is in portrait orientation. Only landscape screenshots are allowed.

Your screenshots are 256x512 - they are rotated 90 degrees. A qFlipper screenshot is 512x256 (landscape) and the catalog only accepts landscape. The images look like correct qFlipper exports, just rotated afterwards.

please commit them in the original orientation as qFlipper saves them by default, without rotating - all 3 (ss0, ss1, ss2). Thanks!

rvonsch reacted with hooray emoji
@xMasterX xMasterX added the fixes needed Unresolved issues with the app requiring maintainer's attention label Jul 19, 2026

rvonsch commented Jul 20, 2026

Copy link
Copy Markdown
Author

Good morning! Strange, qFlipper saved the files to my Mac as vertical screenshots, so it must have rotated them automatically. I manually rotated them to be horizontal and reuploaded them.

xMasterX commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Hi, thanks - the screenshots are landscape and correct now! But bundle stops on the description markdown: "Header Depth max level 2 exceeded".

Your description points to @README.md, and that readme uses markdown the catalog does not allow: h3 headers (README.md:24 "### Method 1...", :28 "### Method 2..."), inline code with backticks (9 of them), and 3 images ![...]. The catalog only allows a small subset - h1/h2 headers, bold, italic, lists and links. No h3+, no backticks, no images.

best is to make a short separate description file (or write it inline in the manifest) using only the allowed markdown, and keep the full readme with install instructions for developers - it just cannot be the catalog description.

rvonsch commented Aug 19, 2026

Copy link
Copy Markdown
Author

Thanks so much! I updated the readme and got rid of the H3 headers, backticks, and images. I appreciate your help. Sorry for the mistakes!

Copy link
Copy Markdown
Collaborator

You need to update commit sha to point to latest commit in your repo

rvonsch reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xMasterX xMasterX xMasterX requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

app (new) fixes needed Unresolved issues with the app requiring maintainer's attention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /