-
Notifications
You must be signed in to change notification settings - Fork 95
chore: remove unsafe fallback in calculate_external_state_root - #481
chore: remove unsafe fallback in calculate_external_state_root #481alessandromazza98 wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want to remove the dry run logic here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nethermind audit suggestion says to treat dry_run and enabled in the same way for this specific thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the logic here for dry run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
essentially for both enabled and dry-run modes, you need to check both the builder AND the l2 node
Stacked on top of #480
This closes best practice 2 of Nethermind security audit