generated from flashbots/flashbots-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 280
Comments
fix(ci): [#842] switch to valid semver naming for releases#885
Open
igladun wants to merge 1 commit intoflashbots:develop from
Open
fix(ci): [#842] switch to valid semver naming for releases #885igladun wants to merge 1 commit intoflashbots:develop from
igladun wants to merge 1 commit intoflashbots:develop from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR changes the Docker image tagging in the release workflow from PEP 440 format to semver. It also updates the
RELEASE.mdto reflect semver naming conventions for releases.Fixes #842
⛱ Motivation and Context
To avoid all kinds of trouble with standardized deployment tools like Helm, etc.
📚 References
#842
https://semver.org/
https://github.com/docker/metadata-action#typesemver
✅ I have run these commands
make lintmake test-racego mod tidy