-
Notifications
You must be signed in to change notification settings - Fork 0
[fix][[program-service] createSchedule 시 totalCapacity 입력 제거 및 remainingCount 값과 일치화, deploy 설정 수정#29
Conversation
- CreateScheduleRequest: totalCapacity 필드 제거 - CreateScheduleCommand: totalCapacity 필드 제거 - ProgramCommandService.createSchedule(): venueValidation.totalCapacity()를 totalCapacity로 직접 사용 - UpdateScheduleRequest / UpdateScheduleCommand: totalCapacity 필드 제거 - ProgramCommandService.updateSchedule(): totalCapacity 관련 검증 제거
Important
Review skipped
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository: first-ticket/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 66c10c2c-8d4a-46f7-8aa8-224276adf333
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
- 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/28-remove-totalCapacity-request-fix-deploy
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
@haeun228
haeun228
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
도커파일이랑 워크플로우는 어떤 이유로 수정하신 걸까요?
CI 실패하는거 수정하시고 머지하시면 될거같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
task definition에 제일 최신 이미지를 사용하도록 설정해놔서 이 부분은 필요 없습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 latest를 푸시하는 건 배포가 제대로 적용되지 않을 수 있다고 들어서 적용했습니다..! Dockerfile에 이상한 부분 때문에 빌드가 실패한 것 같습니다.. 이 부분은 문제 없이 되긴하는데 latest로 통일하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
program-service 입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어쩐지 venue는 배포가 잘 되더라구요 수정하겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분이 중복으로 들어가있네요
haeun228
commented
May 19, 2026
API 변경한 대로 테스트 코드도 수정하셔야 CI 통과될 것 같습니다
🌱 설명
📌 관련 이슈
💻 커밋 유형
📝 체크리스트
📚 추가 설명