-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore(buildkite): add pipeline definition for release QA #5425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+78
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #5425 +/- ## ======================================= Coverage 82.73% 82.73% ======================================= Files 263 263 Lines 27455 27455 ======================================= Hits 22715 22715 Misses 4740 4740
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Release QA pipeline testing in my personal pipeline:
- https://buildkite.com/firecracker/mancio-at-release-qa/builds/14/steps/canvas
- https://buildkite.com/firecracker/mancio-at-release-qa/builds/15/steps/canvas
- this is failing because v1.13.1 doesn't support
/serial, but everything else is alright
- this is failing because v1.13.1 doesn't support
Adds a definition for release QA pipeline to also define it as code in our repository. This also adds a test mode when VERSION=dev where "make_release" is used to generate the artifacts instead of downloading them from S3. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
@Manciukic
Manciukic
force-pushed
the
bk-release-qa
branch
from
September 2, 2025 11:01
bbc44c0 to
8929977
Compare
@Manciukic
Manciukic
added
the
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
label
Sep 2, 2025
JackThomson2
JackThomson2
approved these changes
Sep 3, 2025
zulinx86
zulinx86
approved these changes
Sep 3, 2025
ShadowCurse
ShadowCurse
approved these changes
Sep 3, 2025
@ShadowCurse
ShadowCurse
merged commit Sep 3, 2025
286aa17
into
firecracker-microvm:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Changes
Adds a definition for release QA pipeline to also define it as code in our repository.
This also adds a test mode when VERSION=dev where "make_release" is used to generate the artifacts instead of downloading them from S3.
Reason
The release QA pipeline broke and we fixed it manually. As it wasn't defined in code, it's hard to track and audit changes to it, so we should move it to our repo.
At the same time, we were wondering if we could test this pipeline weekly. This change addresses that by enabling a new mode when "VERSION=dev" that uses
devtool make_releaseto build the release artifacts from main and use them instead of downloading a specific release.By running the pipeline weekly on main with that option we can be notified when
make_releaseor the QA pipeline fail.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.