-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix typo in swagger #5418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Manciukic
merged 2 commits into
firecracker-microvm:main
from
Manciukic:fix-typo-in-swagger
Sep 1, 2025
Merged
Fix typo in swagger #5418
Manciukic
merged 2 commits into
firecracker-microvm:main
from
Manciukic:fix-typo-in-swagger
Sep 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `imds_comat` with the correct `imds_compat`. Fixes: firecracker-microvm#5417 Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Fix another bunch of typos in the swagger spec descriptions. As these are only in the description, this doesn't have any functional change to code generation. - `s/snaphot/snapshot/` - `s/reponds/responds/` Signed-off-by: Riccardo Mancini <mancio@amazon.com>
@Manciukic
Manciukic
added
the
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
label
Sep 1, 2025
zulinx86
zulinx86
approved these changes
Sep 1, 2025
ShadowCurse
ShadowCurse
approved these changes
Sep 1, 2025
thanks a lot for the fix!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #5418 +/- ## ========================================== - Coverage 82.73% 82.73% -0.01% ========================================== Files 263 263 Lines 27455 27455 ========================================== - Hits 22716 22715 -1 - Misses 4739 4740 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
11 tasks
@Manciukic
Manciukic
merged commit Sep 1, 2025
1ba85a7
into
firecracker-microvm:main
8 checks passed
Manciukic
added a commit
to Manciukic/firecracker
that referenced
this pull request
Sep 1, 2025
In firecracker-microvm#5418 I fixed the swagger definition but didn't add it to the changelog. For consistency with the release branch, let's keep it here as well. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Manciukic
added a commit
to Manciukic/firecracker
that referenced
this pull request
Sep 2, 2025
In firecracker-microvm#5418 I fixed the swagger definition but didn't add it to the changelog. For consistency with the release branch, let's keep it here as well. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
roypat
pushed a commit
that referenced
this pull request
Sep 2, 2025
In #5418 I fixed the swagger definition but didn't add it to the changelog. For consistency with the release branch, let's keep it here as well. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix a few typos in swagger
imds_compatparameter ofmmdsendpointsnapshotspelled assnaphotin some descriptionsrespondsspelled asrepondsin a descriptionReason
Fixes #5417.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.