Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: update rust toolchain version #5413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roypat merged 6 commits into firecracker-microvm:main from roypat:toolchain-update
Aug 27, 2025

Conversation

Copy link
Contributor

@roypat roypat commented Aug 27, 2025

Current newest is 1.89.0

Signed-off-by: Patrick Roy roypat@amazon.co.uk## Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.
  • This functionality cannot be added in rust-vmm.

Copy link

codecov bot commented Aug 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 72.56637% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.73%. Comparing base (55abaa8) to head (47c79e3).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/vmm/src/dumbo/tcp/connection.rs 26.92% 19 Missing ⚠️
src/vmm/src/arch/x86_64/mod.rs 37.50% 5 Missing ⚠️
...m/src/devices/virtio/block/virtio/event_handler.rs 25.00% 3 Missing ⚠️
src/vmm/src/devices/legacy/i8042.rs 66.66% 1 Missing ⚠️
src/vmm/src/devices/legacy/serial.rs 66.66% 1 Missing ⚠️
src/vmm/src/devices/virtio/block/device.rs 0.00% 1 Missing ⚠️
src/vmm/src/devices/virtio/block/virtio/device.rs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## main #5413 +/- ##
==========================================
- Coverage 83.13% 82.73% -0.40% 
==========================================
 Files 266 263 -3 
 Lines 30533 27455 -3078 
==========================================
- Hits 25383 22715 -2668 
+ Misses 5150 4740 -410
Flag Coverage Δ
5.10-c5n.metal ?
5.10-m5n.metal 82.84% <71.02%> (-0.39%) ⬇️
5.10-m6a.metal 82.08% <71.02%> (-0.47%) ⬇️
5.10-m6g.metal 79.52% <75.00%> (-0.35%) ⬇️
5.10-m6i.metal 82.83% <71.02%> (-0.40%) ⬇️
5.10-m7a.metal-48xl 82.07% <71.02%> (?)
5.10-m7g.metal 79.52% <75.00%> (-0.35%) ⬇️
5.10-m7i.metal-24xl 82.81% <71.02%> (?)
5.10-m7i.metal-48xl 82.80% <71.02%> (?)
5.10-m8g.metal-24xl 79.52% <75.00%> (?)
5.10-m8g.metal-48xl 79.52% <75.00%> (?)
6.1-c5n.metal ?
6.1-m5n.metal 82.87% <71.02%> (-0.40%) ⬇️
6.1-m6a.metal 82.12% <71.02%> (-0.47%) ⬇️
6.1-m6g.metal 79.52% <75.00%> (-0.35%) ⬇️
6.1-m6i.metal 82.87% <71.02%> (-0.40%) ⬇️
6.1-m7a.metal-48xl 82.12% <71.02%> (?)
6.1-m7g.metal 79.52% <75.00%> (-0.35%) ⬇️
6.1-m7i.metal-24xl 82.88% <71.02%> (?)
6.1-m7i.metal-48xl 82.88% <71.02%> (?)
6.1-m8g.metal-24xl 79.52% <75.00%> (?)
6.1-m8g.metal-48xl 79.52% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
 

Current newest is 1.89.0
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat added 4 commits August 27, 2025 17:01 
Lots of new warnings and lints
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
we go from v83 to v84. Ubuntu version of the base image changed during
the container rebuild, so update that one python doctest.
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
It seems that with the newer kani versions, we need to explicitly pass
--workspace to get it to pick up harnesses from within workspace crates.
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Kani 0.65.0 crashes with ICE when trying to verify firecracker, see also
model-checking/kani#4322
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 27, 2025
@roypat roypat enabled auto-merge (rebase) August 27, 2025 16:31
@roypat roypat merged commit 0b2fd57 into firecracker-microvm:main Aug 27, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manciukic Manciukic Manciukic approved these changes

@JackThomson2 JackThomson2 JackThomson2 approved these changes

@ShadowCurse ShadowCurse ShadowCurse approved these changes

Assignees
No one assigned
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /