Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: pythonify BK definitions for docker and coverage #5412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@Manciukic Manciukic commented Aug 27, 2025 •
edited
Loading

Changes

Define Docker and Coverage pipelines in .buildkite folder as all other pipelines.

Reason

I wanted to remove c5n from all pipelines and found out these 2 pipelines are defined directly on BK website.
Let's move them to python as all the others so that they stay in sync with the latest and greatest updates to the supported platforms and instance types.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.
  • This functionality cannot be added in rust-vmm.

@Manciukic Manciukic force-pushed the python-buildkite-definitions branch 2 times, most recently from 238e728 to 4fafe2d Compare August 27, 2025 11:34
Copy link

codecov bot commented Aug 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.73%. Comparing base (0b2fd57) to head (371a2de).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@ Coverage Diff @@
## main #5412 +/- ##
==========================================
+ Coverage 82.69% 82.73% +0.03% 
==========================================
 Files 263 263 
 Lines 27455 27455 
==========================================
+ Hits 22705 22715 +10 
+ Misses 4750 4740 -10
Flag Coverage Δ
5.10-c5n.metal ?
5.10-m5n.metal 82.84% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.08% <ø> (-0.01%) ⬇️
5.10-m6g.metal 79.52% <ø> (ø)
5.10-m6i.metal 82.83% <ø> (ø)
5.10-m7a.metal-48xl 82.08% <ø> (?)
5.10-m7g.metal 79.52% <ø> (ø)
5.10-m7i.metal-24xl 82.81% <ø> (?)
5.10-m7i.metal-48xl 82.81% <ø> (?)
5.10-m8g.metal-24xl 79.52% <ø> (?)
5.10-m8g.metal-48xl 79.52% <ø> (?)
6.1-m5n.metal 82.88% <ø> (+<0.01%) ⬆️
6.1-m6a.metal 82.12% <ø> (ø)
6.1-m6g.metal 79.51% <ø> (-0.01%) ⬇️
6.1-m6i.metal 82.87% <ø> (ø)
6.1-m7a.metal-48xl 82.12% <ø> (?)
6.1-m7g.metal 79.52% <ø> (ø)
6.1-m7i.metal-24xl 82.88% <ø> (?)
6.1-m7i.metal-48xl 82.88% <ø> (?)
6.1-m8g.metal-24xl 79.52% <ø> (?)
6.1-m8g.metal-48xl 79.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Manciukic Manciukic force-pushed the python-buildkite-definitions branch 3 times, most recently from 5de8945 to 9c40100 Compare August 27, 2025 13:46 
We used to manage these definitions in the BK with no versioning or
source control, let's move them to python as all the others so that they
stay in sync with the latest and greatest updates to the supported
platforms and instance types.
Signed-off-by: Riccardo Mancini <mancio@amazon.com>
@Manciukic Manciukic force-pushed the python-buildkite-definitions branch from 9c40100 to 3af287f Compare August 27, 2025 13:54
Copy link
Contributor Author

@Manciukic Manciukic marked this pull request as ready for review August 27, 2025 15:14
@Manciukic Manciukic added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 27, 2025
@Manciukic Manciukic enabled auto-merge (rebase) August 28, 2025 11:01
@Manciukic Manciukic merged commit 52eefd8 into firecracker-microvm:main Aug 28, 2025
7 checks passed
@Manciukic Manciukic deleted the python-buildkite-definitions branch August 28, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackThomson2 JackThomson2 JackThomson2 approved these changes

@ShadowCurse ShadowCurse ShadowCurse approved these changes

Assignees
No one assigned
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /