Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: drop support for Skylake instances #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manciukic merged 1 commit into firecracker-microvm:main from Manciukic:drop-skylake
Aug 27, 2025

Conversation

Copy link
Contributor

@Manciukic Manciukic commented Aug 27, 2025

Changes

We're dropping official support for our oldest supported instance type. There is no functional change, meaning Firecracker will continue to work on that instance type, but we will drop all automated testing on it.

Reason

Remove unused instance type.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.
  • This functionality cannot be added in rust-vmm.

Copy link
Contributor Author

Manciukic commented Aug 27, 2025 •
edited
Loading

Testing on CPU Templates pipeline: https://buildkite.com/firecracker/cpu-templates/builds/967/steps/canvas

Copy link

codecov bot commented Aug 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.17%. Comparing base (f101299) to head (29c7949).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@ Coverage Diff @@
## main #5411 +/- ##
==========================================
+ Coverage 83.13% 83.17% +0.04% 
==========================================
 Files 266 266 
 Lines 30533 30533 
==========================================
+ Hits 25383 25396 +13 
+ Misses 5150 5137 -13
Flag Coverage Δ
5.10-c5n.metal ?
5.10-m5n.metal 83.23% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.54% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 79.87% <ø> (ø)
5.10-m6i.metal 83.23% <ø> (ø)
5.10-m7a.metal-48xl 82.53% <ø> (?)
5.10-m7g.metal 79.87% <ø> (ø)
5.10-m7i.metal-24xl 83.19% <ø> (?)
5.10-m7i.metal-48xl 83.20% <ø> (?)
5.10-m8g.metal-24xl 79.87% <ø> (?)
5.10-m8g.metal-48xl 79.87% <ø> (?)
6.1-c5n.metal ?
6.1-m5n.metal 83.27% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.58% <ø> (ø)
6.1-m6g.metal 79.87% <ø> (ø)
6.1-m6i.metal 83.27% <ø> (+<0.01%) ⬆️
6.1-m7a.metal-48xl 82.57% <ø> (?)
6.1-m7g.metal 79.87% <ø> (ø)
6.1-m7i.metal-24xl 83.29% <ø> (?)
6.1-m7i.metal-48xl 83.29% <ø> (?)
6.1-m8g.metal-24xl 79.87% <ø> (?)
6.1-m8g.metal-48xl 79.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Manciukic Manciukic force-pushed the drop-skylake branch 2 times, most recently from 733414e to f0ee009 Compare August 27, 2025 11:46
@Manciukic Manciukic marked this pull request as ready for review August 27, 2025 11:46
@Manciukic Manciukic added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 27, 2025 
We're dropping official support for our oldest supported instance type.
There is no functional change, meaning Firecracker will continue to work
on that instance type, but we will drop all automated testing on it.
Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Copy link
Contributor Author

Manciukic commented Aug 27, 2025 •
edited
Loading

I fixed the last thing taka mentioned to make the comment clearer

 # Thus, since the FLUSH_L1D bit is masked off prior to kernel v6.4, guests with
 # IA32_ARCH_CAPABILITIES.FB_CLEAR (bit 17) = 0 (like guests with T2S template which presents
 # an Intel Skylake CPU) fall into the MMIO_MITIGATION_UCODE_NEEDED branch, marking the
 # system as vulnerable to MMIO Stale Data.

@Manciukic Manciukic enabled auto-merge (rebase) August 27, 2025 14:12
@Manciukic Manciukic merged commit 55abaa8 into firecracker-microvm:main Aug 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalyazin kalyazin kalyazin approved these changes

@zulinx86 zulinx86 zulinx86 approved these changes

@xmarcalx xmarcalx Awaiting requested review from xmarcalx xmarcalx is a code owner

@pb8o pb8o Awaiting requested review from pb8o pb8o is a code owner

Assignees
No one assigned
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /