-
Notifications
You must be signed in to change notification settings - Fork 971
fix(ai): Fix test script broken by #9232 #9235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d8194d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsTest Logs |
Size Analysis Report 1Affected Products
Test Logs |
packages/ai/src/factory-browser.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
In the emergency fix for #9232, overlooked that the
factoryexport was being used by a test utility. Refactored so that the test utility can use it without exporting it in the public API.Also added a tsc type check to the tests, that would have caught this.