Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Guard remote config response parsing from empty FlatBuffer #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
triplef wants to merge 2 commits into firebase:main
base: main
Choose a base branch
Loading
from triplef:fix-remoteconfig-crash

Conversation

Copy link

@triplef triplef commented Sep 26, 2025

Description

Guard RemoteConfigResponse::MarkCompleted() from attempting to read a FlatBuffer when the builder holds no data, preventing the desktop Remote Config client from crashing on empty responses.

Fixes #1433.

———

Testing

Not run (Remote Config desktop integration tests depend on internal credentials; change is limited to an early-exit guard).

———

Type of Change

———

Copy link

Summary of Changes

Hello @triplef, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical safeguard to the Remote Config client, specifically within the MarkCompleted() method. By adding a check for empty FlatBuffer data, it prevents potential crashes that would occur if the system attempted to process a response without any content. This ensures the stability and robustness of the desktop Remote Config client when handling various server responses.

Highlights

  • Bug Fix: Addressed an issue where the desktop Remote Config client could crash when attempting to parse an empty FlatBuffer response.
  • Defensive Programming: Implemented a guard condition in RemoteConfigResponse::MarkCompleted() to prevent FlatBuffer parsing if the builder holds no data or has a null buffer pointer.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a crash when parsing an empty remote config response by adding a guard before accessing the FlatBuffer. While the intention is correct, the added check for an empty buffer (GetSize() == 0) is not sufficient to prevent all out-of-bounds access. A malformed response with a very small (but non-zero) body could still cause a crash. I've provided a suggestion to make this check more robust by ensuring the buffer is large enough to contain a root pointer.

 

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Crash in flatbuffers::GetMutableRoot<T>
1 participant

AltStyle によって変換されたページ (->オリジナル) /