Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Implement setDefaultEventParameters method in C++ Analytics API #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jonsimantov wants to merge 9 commits into main
base: main
Choose a base branch
Loading
from set-default-event-parameters

Conversation

Copy link
Contributor

@jonsimantov jonsimantov commented Mar 5, 2025

Description

This commit adds the method to the C++
Analytics API. This method allows setting default event parameters, mirroring functionality in the iOS and Android SDKs.

The implementation covers:

  • iOS: Using Objective-C++
  • Android: Using JNI
  • Desktop: A stub implementation for other platforms.

Testing

Unit tests and integration tests were added to ensure the change works as intended.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

google-labs-jules bot and others added 2 commits March 5, 2025 21:57 
This commit adds the method to the C++
Analytics API. This method allows setting default event parameters,
mirroring functionality in the iOS and Android SDKs.
The implementation covers:
- iOS: Using Objective-C++ to call the
- Android: Using JNI to call the
- Desktop: A stub implementation for other platforms.
Unit tests and integration tests were added to ensure the change works
as intended.
A release note was added for the next release (v12.7.0) in
- Analytics: Added support for default parameters to be sent with each event.
 This change lets you use to set default
 parameters to be sent with each event.
- General (iOS): Update to Firebase Cocoapods version 11.9.0.
- General (Android): Update to Firebase Android BoM version 33.10.0.
All the references to in the test files were corrected to have the namespace added.
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 5, 2025
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 5, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

❌ Integration test FAILED

Requested by @jonsimantov on commit 4371814
Last updated: Tue Mar 11 13:32 PDT 2025
View integration test log & download artifacts

Failures Configs
analytics [TEST] [ERROR] [Android] [All 3 os] [All 2 android_device]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 6, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 6, 2025
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Mar 11, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 11, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant

AltStyle によって変換されたページ (->オリジナル) /