-
Notifications
You must be signed in to change notification settings - Fork 125
Auth rewrite #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth rewrite #1254
Conversation
Update auth internals to support returning Future object for the new API while also support returning Future<User*> objects for the deprecated API on iOS. Changes does not include the new Future methods.
Removes the need for User objects to be stored in AuthData, unlocking ability for there to be more than one User object at a time. Continues to store a User in Auth, though, to maintain the implementation of the newly deprecated methods which return a User*. Added a RetainUser integration test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: [3 lines down] warning: More #endif's than #if's found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: Found unknown command '\CreateUserWithEmailAndPassword'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: Found unknown command '\current_user'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: Found unknown command '\SignInAndRetrieveDataWithCredential'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: Found unknown command '\SignInWithCredential'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'ReauthenticateAndRetrieveData' for \ref command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'ReauthenticateWithProvider(FederatedAuthProvider*)' for \ref command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation issue: warning: unable to resolve reference to 'UpdatePhoneNumberCredential(const PhoneAuthCredential&)' for \ref command
Description
Feature branch, do not merge.
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.