-
Notifications
You must be signed in to change notification settings - Fork 343
#678 fixed removing email from userRecord via update_user #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adeline09
commented
Dec 11, 2023
Description of changes:
In firebase_admin/_user_mgt.py we changed the email validation in the payload to include the condition that checks whether email should be deleted via DELETE_ATTRIBUTE. Also we wrote the function to delete email from the database upon checking DELETE_ATTRIBUTE.
Description of tests:
In tests/test_user_mgt.py we included corresponding fields for email in the function test_update_user_delete_fields. Then we wrote the function test_update_user_delete_provider_and_email that verifies email deletion from the database in the same manner as phone number deletion.
prameshj
commented
Dec 19, 2023
cc @renkelvin
Discussion
This PR resolves issue #678.
Testing
Suggestions are welcomed for further testing.