Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

#678 fixed removing email from userRecord via update_user #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smithlauren910 wants to merge 2 commits into firebase:master
base: master
Choose a base branch
Loading
from smithlauren910:master

Conversation

Copy link

@smithlauren910 smithlauren910 commented Dec 11, 2023

Discussion

This PR resolves issue #678.

Testing

Suggestions are welcomed for further testing.

jifalops reacted with thumbs up emoji
Copy link

Description of changes:
In firebase_admin/_user_mgt.py we changed the email validation in the payload to include the condition that checks whether email should be deleted via DELETE_ATTRIBUTE. Also we wrote the function to delete email from the database upon checking DELETE_ATTRIBUTE.

Description of tests:
In tests/test_user_mgt.py we included corresponding fields for email in the function test_update_user_delete_fields. Then we wrote the function test_update_user_delete_provider_and_email that verifies email deletion from the database in the same manner as phone number deletion.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prameshj prameshj Awaiting requested review from prameshj

At least 1 approving review is required to merge this pull request.

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /