-
-
Notifications
You must be signed in to change notification settings - Fork 72
Update beautiful dnd example #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erikras
merged 1 commit into
final-form:master
from
tim-mccurrach:update-beautiful-dnd-example
Jul 13, 2020
Merged
Update beautiful dnd example #135
erikras
merged 1 commit into
final-form:master
from
tim-mccurrach:update-beautiful-dnd-example
Jul 13, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Merging #135 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #135 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 6 Lines 60 60 Branches 10 10 ========================================= Hits 60 60
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update b40b90d...64d85c3. Read the comment docs.
@github-actions
github-actions
bot
locked as resolved and limited conversation to collaborators
May 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix React beautiful dnd example
Thanks, for the library :) I've very much enjoyed using final-forms. The current example with
react-beautiful-dndhere uses the following formakeOnDragEndFunctiondrop:This has the effect, that if you start off with
#1, #2, #3, #4and you move#4to the second position, then after the drop,#2jumps to the end position, which is unexpected. I have forked the example on sandbox, and updated this line to become:and also updated the link in the readme to the new sandbox.