Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Code Quality: Use Satori GC for x64 and arm64 package #17487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaira2 merged 5 commits into files-community:main from hez2010:satori
Sep 4, 2025

Conversation

Copy link
Member

@hez2010 hez2010 commented Aug 23, 2025
edited
Loading

This can improve the overall performance, memory footprint and responsiveness.
Note: this only affects the package. It won't kick in during the build process.

I'm maintaining the Satori GC build in a separate repository.

Also, bump the Windows SDK version to 26100.

Copy link
Member

0x5bfa commented Aug 24, 2025

Will we set latency mode for the compaction?

Copy link
Member Author

hez2010 commented Aug 24, 2025
edited
Loading

Will we set latency mode for the compaction?

Maybe not. For the desktop app, we prefer a smaller memory footprint, especially when the latency of interactive mode is already low.

Copy link
Member Author

hez2010 commented Aug 24, 2025

Hmmm based on my observation it seems that it would be better to enable LowLatency mode. Need to verify the memory consumption.

Copy link
Member Author

hez2010 commented Aug 24, 2025

With LowLatency mode the memory grows very aggressively.
I think we need to stick with the default interactive mode.

It's slightly better than WKS GC btw, but not that observable.

0x5bfa reacted with thumbs up emoji

Copy link
Member

yaira2 commented Aug 24, 2025

The package size is 1mb smaller.

@yaira2 yaira2 changed the title (削除) Use Satori GC for x64 and arm64 package (削除ここまで) (追記) Code Quality: Use Satori GC for x64 and arm64 package (追記ここまで) Aug 26, 2025
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 4, 2025
@yaira2 yaira2 merged commit a6b39a9 into files-community:main Sep 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /