-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Code Quality: Removed extra code for async ops in Program class #17100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Requesting your review @dongle-the-gadget @hez2010
fc48386 to
eca313e
Compare
Ready
I think it's better to do something like
public Task Something(Task task) { async Task Call() { await task; SetEvent(); } }
42c8207 to
4c7493f
Compare
@0x5bfa fyi
@ahmed605 What is your opinion too? I can't be sure the current code and the above code is really non blocking.
What's the state of this PR?
eca313e to
fab5674
Compare
Committed the requested change. Itested the change in RedirectActivationTo on my local but didn't test the one in OpenFileFromTile as I don't have Windows 10 rn.
PTAL. CC: @ahmed605
LGTM
Resolved / Related Issues
Steps used to test these changes