-
-
Notifications
You must be signed in to change notification settings - Fork 397
refactor(tokenizer): Use decorators for even faster parsing#1011
Draft
fb55 wants to merge 1 commit into
Draft
Conversation
@fb55
fb55
changed the title
(削除) refactor: Use decorators for even faster parsing (削除ここまで)
(追記) refactor(tokenizer): Use decorators for even faster parsing (追記ここまで)
Nov 12, 2021
coveralls
commented
Nov 12, 2021
Pull Request Test Coverage Report for Build 1454072605
💛 - Coveralls |
This leads to another ~5% speed-up. Not sure if it is worth it though, as the code does get quite a bit less understandable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leads to another ~5% speed-up. Not sure if it is worth it though, as the code does get quite a bit less understandable.