@tiangolo @alejsdev or some other maintainer... could you please review this issue?

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

@stickM4N, could you please clarify why this should be treated as breaking change?

Apart from that, should we add a test for new parameter?

Hi @YuriiMotov, nice to hear from you again.
Sorry for not have given a better description for the problem, but here it is:

from sqlmodel import SQLModel, Field
class MyClass(SQLModel):
 id: str = Field(unique=True, pattern=r"^\d{5}$")

This code raises TypeError: Field() got an unexpected keyword argument 'pattern' which is the intended keyword for pydantic.v2.FieldInfo, differet from regex for pydantic.v1.FieldInfo
The aim of this PR is to make them compatible and have the same logic for both version sqlmodel-wise

I have other proposition that is more comfortable to work with in my opinion, but its more of a change... and its to convert schema_extra param to **schema_extra, so the input from sqlmodel.Field is more flexible, should not have impacts in other places and it add flexibility to implementations and simpler way to migrate from pydantic.Field to sqlmodel.Field

Since we still support regex parameter and just add alias (pattern) and make it working with Pydantic V2, I wouldn't call these changes braking.
So, I would remove the mention of breaking.

Also, I think we should mark regex as deprecated and prioritize pattern over regexp regardless the version of Pydantic.

Still we need to add some test:

• pass regex and validate valid\invalid value
• pass pattern and validate valid\invalid value
• pass both regex and pattern and see that pattern is used
• don't pass pattern directly, but pass schema_extra={"pattern": r"..."} (workaround that is currently being used to make it working with Pydantic V2) - it should still work

Noted @YuriiMotov, I will do that.
Here there is the reference to the removed parameter and error raise associated to it. Here is its implementation.

I would like to propose the following change:

def Field(default, *, ..., **schema_extra)

rather than

def Field(default, *, ..., schema_extra)