-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
feat(config): add support for separate test database via .env.test #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi maintainers!
The check-labels workflow is currently failing because it requires one of the following labels:
breaking, security, feature, bug, refactor, upgrade, docs, lang-all, or internal.
Could you please add one of them? I believe feature would be appropriate in this case.
Thank you very much!
@EmiFunes91
EmiFunes91
force-pushed
the
fix/separate-test-dev-db
branch
from
May 18, 2025 05:07
b3f8eb1 to
d4469b9
Compare
@EmiFunes91
EmiFunes91
force-pushed
the
fix/separate-test-dev-db
branch
from
May 18, 2025 05:15
d4469b9 to
f95084d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR adds support for a dedicated PostgreSQL test database by introducing a
.env.testfile and adapting the config logic to switch automatically based on theENVIRONMENTvariable.What’s in this PR
.env.testfile withENVIRONMENT=testandPOSTGRES_DB=app_testconfig.pyto dynamically load the correct databaseWhy
Right now, both development and test environments point to the same DB (
app), which can lead to data conflicts during CI runs or local testing.This solves Issue #125 by making test isolation simple and configuration-driven—no breaking changes introduced.
Additional Notes
.env.testis included by default — let me know if you’d prefer it excluded via.gitignore