-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
♻️ Send account creation email asynchronously via BackgroundTasks #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saleemasekrea000
wants to merge
3
commits into
fastapi:master
from
saleemasekrea000:feature/background-email
Open
♻️ Send account creation email asynchronously via BackgroundTasks #1505
saleemasekrea000
wants to merge
3
commits into
fastapi:master
from
saleemasekrea000:feature/background-email
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alejsdev
alejsdev
changed the title
(削除) send account creation email asynchronously via BackgroundTasks (削除ここまで)
(追記) ♻️ Send account creation email asynchronously via BackgroundTasks (追記ここまで)
Feb 21, 2025
@alejsdev
Hi, is there any kind of feedback?
It's been a long time...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it a background task improves responsiveness and user experience.
For future
If you need to perform heavy background computation and you don't necessarily need it to be run by the same process (for example, you don't need to share memory, variables, etc), you might benefit from using other bigger tools like Celery
According to the FastAPI docs :
https://fastapi.tiangolo.com/tutorial/background-tasks/?h=#technical-details