-
Notifications
You must be signed in to change notification settings - Fork 108
composer、PSR-4 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
composer、PSR-4 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
fanfank
commented
Oct 31, 2017
哈喽 @xcorp1986 ,很感谢你为这个项目做了这些更与时俱进的改动!
但是目前 Phpfetcher 暂时仍然希望保留原本的代码结构,主要原因是我个人目前比较少去维护这个项目,相关的文档、demo等也要逐个进行新代码的适配。
在后续的PHP项目中(如果我会开发的话···),一定会采用更与时俱进的方式去完成
Author
xcorp1986
commented
Dec 3, 2017
代码结构差不多,主要是psr-4和命名空间的形式更加一目了然,偶然见到这个项目,手痒pr了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
详见changelog
demo基本跑通,个别notice可以留意一下