forked from madskristensen/WebCompiler
-
Notifications
You must be signed in to change notification settings - Fork 18
The SCSS compile Scss test is failing due to a change of URL#81
Open
garyhuntddn wants to merge 1 commit into
Open
The SCSS compile Scss test is failing due to a change of URL #81garyhuntddn wants to merge 1 commit into
garyhuntddn wants to merge 1 commit into
Conversation
...ing the code produces the right result then this patch fixes the test to include the ../ prefix
garyhuntddn
commented
Jun 20, 2023
Author
Following on from the re-write of the MakeRelative function I've done in the other PR - be careful accepting this as it might not be correct. It might make the test pass - but I can't determine yet whether it's the code or the test at fault.
Velociraptor45
commented
Jul 31, 2023
Only seeing this PR now - from what I understand the test is correct but the MakeRelative function is never called due to an error in the node execution, see #86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming the code produces the right result then this patch fixes the test to include the ../ prefix