This repository was archived by the owner on Jan 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 413
Comments
Switch workers to system_unbound_wq.#229
Open
byo wants to merge 1 commit intofacebookarchive:master from
Open
Switch workers to system_unbound_wq. #229byo wants to merge 1 commit intofacebookarchive:master from
byo wants to merge 1 commit intofacebookarchive:master from
Conversation
This patch does greatly reduce the probability of kernel hang caused by memory reclamation executed through flashcache's code. The probability is reduced because io required by memory reclamation can use thread spawned on different cores. The correct patch would be to create dedicated workqueue with WQ_MEM_RECLAIM but this patch is relatively unintruisive and does provably fix the issue in prodiction environments. Signed-off-by: Bartłomiej Święcki <bartlomiej.swiecki@corp.ovh.com>
facebook-github-bot
commented
Dec 8, 2017
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.
If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch does greatly reduce the probability of
kernel hang caused by memory reclamation executed
through flashcache's code.
The probability is reduced because io required by memory
reclamation can use thread spawned on different cores.
The correct patch would be to create dedicated workqueue
with WQ_MEM_RECLAIM but this patch is relatively unintruisive
and does provably fix the issue in prodiction environments.
Signed-off-by: Bartłomiej Święcki bartlomiej.swiecki@corp.ovh.com