-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Build: Add -mno-strict-align flag for RISC-V architecture#4584
Open
Polaris-911 wants to merge 1 commit intofacebook:dev from
Open
Build: Add -mno-strict-align flag for RISC-V architecture #4584Polaris-911 wants to merge 1 commit intofacebook:dev from
-mno-strict-align flag for RISC-V architecture #4584Polaris-911 wants to merge 1 commit intofacebook:dev from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the root
Makefileto automatically detect RISC-V architectures (viauname -m) and append the-mno-strict-alignflag toMOREFLAGS.On many RISC-V implementations standard builds can suffer from significant performance degradation. Adding
-mno-strict-aligninstructs the compiler to generate code that handles unaligned accesses via byte-wise instructions or other safe methods, thereby avoiding expensive traps and improving runtime performance.Changes
riscv%inUNAME_M.-mno-strict-aligntoMOREFLAGS.MOREFLAGSto ensure the flag is correctly propagated to sub-makefiles (lib, programs, etc.).Validation & Benchmarks
Tested on a RISC-V device (Sophon SG2044 / 64-core RISC-V).
Benchmark Environment:
Results:
Comparison between the original build and the build with
-mno-strict-align.-mno-strict-align(Note: Data collected using
zstd -bbenchmark)