-
Notifications
You must be signed in to change notification settings - Fork 347
Comments
renderdag: box: option to pad between nodes from separate branches#1163
renderdag: box: option to pad between nodes from separate branches #1163thomasa88 wants to merge 3 commits intofacebook:main from
Conversation
Makes it easier to visually scan the branches and find the heads quickly. Before: │ │ │ o F some text message │ ├───╯ that continues on the next line │ │ │ o E some text message │ ├───╯ that continues on the next line │ │ o D some text message │ │ │ that continues on the next line │ │ o C some text message │ │ │ that continues on the next line │ o │ B some text message │ ├─╯ that continues on the next line │ o A some text message ├─╯ that continues on the next line After: │ │ │ o F some text message │ ├───╯ that continues on the next line │ │ │ │ │ │ o E some text message │ ├───╯ that continues on the next line │ │ │ │ │ o D some text message │ │ │ that continues on the next line │ │ o C some text message │ │ │ that continues on the next line │ │ │ │ o │ B some text message │ ├─╯ that continues on the next line │ o A some text message ├─╯ that continues on the next line
90f5bb8 to
f0d2cc3
Compare
facebook-github-bot
commented
Dec 13, 2025
@thomasa88 has updated the pull request. You must reimport the pull request before landing.
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D89118021. (Because this pull request was imported automatically, there will not be any future comments.)
@quark-zju
quark-zju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
quark-zju
commented
Feb 24, 2026
Sorry for the slow review. In your example it seems inconsistent that there are no spaces between (A, B), or (D, C) but there are spaces between (E, F), (B, C), and (D, E).
If you want more spaces, have you tried appending new lines \n to "that continues on the next line", or use the with_min_row_height(3) API?
@quark-zju
quark-zju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
Uh oh!
There was an error while loading. Please reload this page.
Makes it easier to visually scan the branches and find the heads quickly.
Before:
After: