-
Notifications
You must be signed in to change notification settings - Fork 797
Add print capture variables for pblock #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
before:
Imp: 0x10a451d40 Signature: void ^();
after:
Imp: 0x10a451d40 Signature: void ^() Variables : {
<ViewController: 0x7fdd9b204060>
<AppDelegate: 0x60c00002acc0>
};
@kastiglione
kastiglione
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a nice addition. I have some questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the change to setValue:forKey:?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commands/FBClassDump.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why up to 10?
commands/FBClassDump.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain min_var_count and max_var_count? I'm not clear on their purpose.
dhcdht
commented
May 22, 2018
@kastiglione
hi, I have added some comments for max_var_count.
max_var_count is the number of placeholders for the variables captured by the block.
the related code
#define BLOCK_VARIABLES_COUNT ($variables_count)
struct Block_literal_1 {
...
// imported variables
Class *variables[BLOCK_VARIABLES_COUNT];
}
984dc89 to
a31c1f4
Compare
filip-doordash
commented
Mar 25, 2020
I think this is super useful! Is this something that is still in progress? If not, I'd be happy to take a stab at the implementation myself.
before:
Imp: 0x10a451d40 Signature: void ^();
after:
Imp: 0x10a451d40 Signature: void ^() Variables : {
<ViewController: 0x7fdd9b204060>
<AppDelegate: 0x60c00002acc0>
};