Skip to content

Navigation Menu

Sign in
Sign up

docs: define React update propagation contract - #6089

Draft
cixzhang wants to merge 4 commits into
main from
stepper-registration-contract
Draft

docs: define React update propagation contract #6089
cixzhang wants to merge 4 commits into
main from
stepper-registration-contract

Conversation

@cixzhang

@cixzhang cixzhang commented Sep 6, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • defines shared React update-propagation boundaries for pre-paint upward writes, membership, mutable metadata, context fan-out, and render isolation
  • projects the shared boundary into Stepper through lifecycle-stable membership and focused propagation evidence
  • constrains horizontalOptions.minimumStepWidth to finite non-negative pixel numbers; CSS strings, units, calc(), and custom properties are unsupported
  • keeps exported StepperContextValue / useStepperContext unchanged from v0.5.2 and moves collapsed-layout coordination to a separate private, non-exported context
  • admits private isCollapsed and a parent-owned Collapsed summary render capability while rejecting raw DOM summarySlot exchange
  • keeps Frame as named structural anatomy with an intentional none theming disposition and removes astryx-stepper-frame from published target metadata
  • records the current hidden threshold probe, added exported context fields, and emitted Frame selector as implementation adoption gaps rather than public contract
  • replaces old review-status prose with durable compatibility requirements

Governance

The records define reusable authority. They do not approve, classify, designate, or authorize a specific pull request. Historical pull requests may appear only as evidence.

Verification

  • node scripts/check-knowledge.mjs
  • pnpm --filter @astryxdesign/core typecheck:docs
  • generated astryx component Stepper --dense omits Frame target and shows number-only minimumStepWidth
  • Prettier
  • git diff --check

No runtime implementation change. No changeset.

vercel Bot commented Sep 6, 2026
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 6, 2026 3:53pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 6, 2026
@github-actions github-actions Bot added the needs:spec-owner-review Current knowledge records await owner approval label Sep 6, 2026

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

Preview availability: CI did not succeed, so no preview was published.

Modified Components

Stepper (@astryxdesign/core)
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 1608 -
Complexity N/A Very High (191) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: 1 accessibility violation(s) found — 1 serious.

Stepper - 1 issue(s)
  • 🟠 serious: Ensure the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds
    • Rule: color-contrast · Affects 1/30 stories · Learn more
    • WCAG: 1.4.3 (Level AA)

Generated by PR Enrichment workflow | View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imdreamrunner imdreamrunner Awaiting requested review from imdreamrunner imdreamrunner will be requested when the pull request is marked ready for review imdreamrunner is a code owner
@josephfarina josephfarina Awaiting requested review from josephfarina josephfarina will be requested when the pull request is marked ready for review josephfarina is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot. needs:spec-owner-review Current knowledge records await owner approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /