-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(core): scale TextInput/TextArea control type with size; add text-input-control theme target - #6086
Open
ManoharPaturi wants to merge 1 commit into
Open
feat(core): scale TextInput/TextArea control type with size; add text-input-control theme target #6086ManoharPaturi wants to merge 1 commit into
ManoharPaturi wants to merge 1 commit into
Conversation
...-input-control theme target
ManoharPaturi
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
September 6, 2026 06:57
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Sep 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
@github-actions
github-actions
Bot
added
community
Authored by a community contributor (not on the eng/design team)
needs:code-review
High-risk change (new package/component/API) — needs human code review before merge
needs:design-review
Affects visuals — Design should review
labels
Sep 6, 2026
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
September 6, 2026 06:57
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsTextArea (@astryxdesign/core) · View in Storybook
TextInput (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Visual RegressionStatus: No visual change across 4 compared shot(s). Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6014
Summary
Both asks from the issue:
sizeforTextInputandTextArea:sm→--text-supporting-size/leading,md→ body,lg→--text-large-size/leading(the repo'stypeScaleVars; these wrap the raw--font-font-size-*tokens the issue measured). Previously only the control height changed — asminput squeezed body text into 24px and anlgfloated 14px text in 40px. The coarse-pointermax(1rem, ...)floor is kept per size;lgTextArea keeps its padding step.text-input-controltheme target on the<input>element — a bare target exactly mirroring the existingtext-area-control— so themes can key off the control surface;data-sizestays on theastryx-text-inputwrapper.Tests
+6 in
TextInput.test.tsx(control target rendered, wrapper-onlydata-size, per-sizetoHaveStylevar assertions, default) and +3 inTextArea.test.tsx, following existing style.Note for the reviewer
packages/themes/probe/src/probeTheme.tsis regenerated (visual:probe-theme) — it picks up this PR's new target plus pre-existing drift onorigin/main(stepper targets, the merged toggle-button elevation selectors); main currently fails the probe check without a regen, so this brings it back in sync.Verification
Targeted suites 576 passed (TextInput 78, TextArea 86, theming-targets guard 412);
tsc --noEmitclean; eslint 0 errors; probe check current (277 targets / 892 selectors); allcheck:reposcripts pass. Docs updated in EN/zh/dense; changeset included.