Skip to content

Navigation Menu

Sign in
Sign up

perf(ci): give the heavier test lane the larger runner #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Han5991 wants to merge 1 commit into facebook:main
base: main
Choose a base branch
Loading
from Han5991:ci/swap-test-lane-runners
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/ci.yml
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,21 +162,22 @@ jobs:
#
# The projects are independent by construction (see vitest.config.ts: `ui` is
# jsdom + StyleX, `node` is everything else), so running them as two jobs
# costs no duplicate execution and each lane carries roughly half the work.
# `node` is the heavier lane — locally 570s against the ui project's 244s —
# so it takes the larger supported runner while `ui` stays on the 2-core arm
# box.
# costs no duplicate execution. They do NOT carry half the work each: on this
# CI, `ui` is ~5x the heavier lane, so it takes the larger runner.
#
# The repo-wide guardrail steps ride the LIGHTER lane, so the slow one is
# nothing but tests.
# The earlier local figure that put `node` ahead (570s vs 244s) was not a
# comparable measurement — only the node run was bounded to a small worker
# pool, and node is the project whose cost is per-assertion CLI subprocesses.
#
# The repo-wide guardrail steps ride `test-ui` (~18s of it).
#
# `test` remains a job, so the required check of that name still exists and
# still reports for every PR. This mirrors the `build` join over
# build-storybook + build-sandbox below.
test-ui:
needs: [check-scope]
if: ${{ always() && !cancelled() }}
runs-on: 2-core-ubuntu-arm
runs-on: 4-core-ubuntu
permissions:
contents: read
steps:
Expand Down Expand Up @@ -233,7 +234,7 @@ jobs:
test-node:
needs: [check-scope]
if: ${{ always() && !cancelled() }}
runs-on: 4-core-ubuntu
runs-on: 2-core-ubuntu-arm
permissions:
contents: read
steps:
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/deploy.yml
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,11 @@ jobs:
# independent by construction (vitest.config.ts), so they split cleanly; the
# typecheck gates need the `pnpm build` they follow, so they stay together in
# their own lane and take the build with them.
#
# `ui` is the heavier project by ~4x here, so it takes the larger runner (see
# ci.yml's lane comment).
test-ui:
runs-on: 2-core-ubuntu-arm
runs-on: 4-core-ubuntu
permissions:
contents: read
steps:
Expand All @@ -93,7 +96,7 @@ jobs:
- run: pnpm vitest run --project ui

test-node:
runs-on: 4-core-ubuntu
runs-on: 2-core-ubuntu-arm
permissions:
contents: read
steps:
Expand Down
Loading

AltStyle によって変換されたページ (->オリジナル) /