-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs(theme-neutral): document Figtree and its loading snippet - #6079
Open
AKnassa wants to merge 3 commits into
Open
docs(theme-neutral): document Figtree and its loading snippet #6079AKnassa wants to merge 3 commits into
AKnassa wants to merge 3 commits into
Conversation
The README and the CLI theme docs described Neutral as a system-font theme while neutralTheme declares Figtree for body and heading. Figtree is not bundled or loaded, so a clean consumer app silently falls back to system fonts and the missing webfont reads as an integration failure. Describe Neutral as Figtree typography in both places, add the Stone-style Fonts section with the Google Fonts snippet to the README, and guard README/theme drift with a colocated test that derives the declared webfonts from the resolved --font-family-* tokens. Fixes facebook#5991
Some apps picked Neutral precisely because nothing external loads (offline apps, no-third-party-request policies). Frame skipping the webfont as a supported choice rather than a failure state, so the new Fonts section keeps that audience. Part of facebook#5991
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Sep 5, 2026
@github-actions
github-actions
Bot
added
community
Authored by a community contributor (not on the eng/design team)
needs:code-review
High-risk change (new package/component/API) — needs human code review before merge
needs:design-review
Affects visuals — Design should review
labels
Sep 5, 2026
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
September 5, 2026 21:39
Widen the README guard to the theme's whole font surface: every --font-family-* token by prefix plus component-level fontFamily overrides, with var() aliases (nested included) stripped before parsing. Tie the loading-recipe assertion to each declared webfont (family= URL token or @font-face) instead of a blanket regex the mutation run proved vacuous. Add a CLI-side guard pinning the astryx docs theme Neutral row via collectUnloadedFonts, so the system-fonts claim cannot return on the surface the README test cannot see. All three guards are mutation-proven: URL font swap, undocumented webfont injection, and doc-row revert each fail exactly the intended assertion. Part of facebook#5991
Contributor
PR Analysis Report
No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Visual Regression2 of 348 shot(s) changed. View the report A repository maintainer can accept these exact frames: A change here is a question, not a failure: check whether the after is the
ComplexSelector — Fruit ripeness selector — neutral light
ComplexSelector — Fruit ripeness selector — neutral dark
Generated by PR Enrichment workflow | View full report |
AKnassa
marked this pull request as ready for review
September 6, 2026 05:18
AKnassa
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
September 6, 2026 05:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #5991
What this does
Makes the Neutral theme honest about its font. The docs said "system fonts", but the theme actually asks for Figtree, a webfont the app has to load itself. Anyone who followed the docs got a silent fallback with no clue why.
Why
A missing webfont looks like an integration failure. Per #5047 and #5048 ("enable rather than deter"), the fix keeps Figtree and documents it instead of stripping the theme back to system fonts. Direction matches @Kyujenius's analysis on the issue.
What changed
astryx docs themetable row for Neutral now names Figtree too.How to check
Read packages/themes/neutral/README.md, Fonts section, or run
astryx docs themeand find the Neutral row.The edge-case test round has landed: the guards now cover the theme's full font surface and the CLI docs row, each proven by mutation testing.