Skip to content

Navigation Menu

Sign in
Sign up

docs(spec): require outermost DOM styling target - #6066

Draft
imdreamrunner wants to merge 1 commit into
main from
spec/outermost-dom-style-props
Draft

docs(spec): require outermost DOM styling target #6066
imdreamrunner wants to merge 1 commit into
main from
spec/outermost-dom-style-props

Conversation

@imdreamrunner

@imdreamrunner imdreamrunner commented Sep 5, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Proposes one rule: when a stable Core component accepts style, className, or xstyle, every accepted prop applies to the same outermost DOM element. A component without one stable root must not expose unsupported general styling props.

Why

Today Astryx requires accepted styling props to be forwarded and composed, but does not define their DOM target. Consumers may need implementation knowledge to know whether they style a wrapper, inner control, or detached surface.

Semantic delta

Before: accepted styling props may target the component's chosen contract element.

After (proposed): they target the same outermost DOM element on every render path.

Existing components

Popover, ContextMenu, OverflowList, Stack, PowerSearch, MultiSelector, and wrapped inputs have shapes or contracts that conflict with the proposed rule. They are not all violations of the current contract: Popover explicitly follows its current surface-styling contract. The proposal requires owners to choose migrations before the rule can become authoritative.

Scope

Specification only. No runtime behavior or public types change in this PR.

Verification

  • pnpm check:knowledge
  • Prettier
  • git diff --check
  • Independent focused review

No Changeset: specification only.

vercel Bot commented Sep 5, 2026
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 5, 2026 4:20am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 5, 2026
imdreamrunner force-pushed the spec/outermost-dom-style-props branch 2 times, most recently from 6915fcc to f603c06 Compare September 5, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cixzhang cixzhang Awaiting requested review from cixzhang cixzhang will be requested when the pull request is marked ready for review cixzhang is a code owner
@josephfarina josephfarina Awaiting requested review from josephfarina josephfarina will be requested when the pull request is marked ready for review josephfarina is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /