-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs(spec): require outermost DOM styling target - #6066
Draft
imdreamrunner wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Sep 5, 2026
imdreamrunner
force-pushed
the
spec/outermost-dom-style-props
branch
from
September 5, 2026 04:11
d1559ed to
29975e7
Compare
imdreamrunner
force-pushed
the
spec/outermost-dom-style-props
branch
2 times, most recently
from
September 5, 2026 04:15
6915fcc to
f603c06
Compare
imdreamrunner
force-pushed
the
spec/outermost-dom-style-props
branch
from
September 5, 2026 04:17
f603c06 to
dc40780
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Proposes one rule: when a stable Core component accepts
style,className, orxstyle, every accepted prop applies to the same outermost DOM element. A component without one stable root must not expose unsupported general styling props.Why
Today Astryx requires accepted styling props to be forwarded and composed, but does not define their DOM target. Consumers may need implementation knowledge to know whether they style a wrapper, inner control, or detached surface.
Semantic delta
Before: accepted styling props may target the component's chosen contract element.
After (proposed): they target the same outermost DOM element on every render path.
Existing components
Popover, ContextMenu, OverflowList, Stack, PowerSearch, MultiSelector, and wrapped inputs have shapes or contracts that conflict with the proposed rule. They are not all violations of the current contract: Popover explicitly follows its current surface-styling contract. The proposal requires owners to choose migrations before the rule can become authoritative.
Scope
Specification only. No runtime behavior or public types change in this PR.
Verification
pnpm check:knowledgegit diff --checkNo Changeset: specification only.