-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Sep 4, 2026
cixzhang
commented
Sep 5, 2026
Contributor
/approve-spec e406a84
cixzhang
cixzhang
approved these changes
Sep 5, 2026
@cixzhang
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for consolidating the shared bidirectionality design intent. Approved at exact head e406a8402eb4b94e719b3ccea91bb4038c23f3c2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Astryx has RTL implementation guidance and browser audits, but no current human-owned record defining what correct bidirectional behavior means. Reviewers can see whether pixels changed without having one authority for what should mirror, what should remain physical, and how interaction meaning should change.
Changes
Add a draft
design:bidirectionalityrecord covering:dirsemantics;The touch-target requirement incorporates the review lesson from #5177: proving center alignment alone is not enough. Target size remains owned by AST-020 and the applicable component/composition contracts.
This stays separate from audit mechanics and the component-audit rubric. The design record says what people should experience; evidence architecture says what proves it; component contracts adopt the relevant requirements.
This PR is intentionally draft and remains non-authoritative until design-owner approval. Its architecture references must be promoted before, or together with, this record.
Test plan
node scripts/check-knowledge.mjsgit diff --check