-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Draft
Conversation
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Sep 4, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report
Preview availability: Storybook and Sandbox were not published for this CI run.
No new or modified components detected.
Bundle Size Summary
No component packages changed.
Accessibility Audit
Status: No accessibility violations detected.
Generated by PR Enrichment workflow | View full report
cixzhang
commented
Sep 5, 2026
Contributor
/approve-spec a1a63a9
cixzhang
cixzhang
approved these changes
Sep 5, 2026
@cixzhang
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for separating measured RTL evidence, verified non-applicability, historical coverage debt, and merge-gate policy instead of treating one implementation as already decided. Approved as the canonical RTL audit-evidence record at exact head a1a63a9238fe5d382cb49b3b3c493b6d48e83ed3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The RTL audit currently mixes implemented checks, proposed verified-N/A handling, and proposed known-debt handling. An all-N/A result can be mistaken for positive RTL evidence, while source lint, browser geometry, interaction checks, and screenshots prove different things.
Changes
Add a draft
architecture:rtl-audit-evidencerecord that:The draft explicitly records that D7 checks hit-testing and center alignment but does not yet enforce target size. It also records that the reason-only verified-N/A registry detects newly applicable dimensions but does not bind evidence to source/story bytes.
Decisions needed before promotion
The draft also calls out the missing
architecture:bidirectional-layoutowner for shared RTL implementation mechanics; this evidence record does not claim that ownership.This PR is intentionally draft and remains non-authoritative until those policy choices are approved.
Test plan
node scripts/check-knowledge.mjsgit diff --check