-
Notifications
You must be signed in to change notification settings - Fork 324
[Repo Assist] [JS/TS] Fix String.IndexOf/LastIndexOf ignoring StringComparison argument#4451
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
Route IndexOf/LastIndexOf with StringComparison to new library functions indexOfWith/lastIndexOfWith in String.ts, which correctly handle all StringComparison values (Ordinal, OrdinalIgnoreCase, CurrentCulture, CurrentCultureIgnoreCase, InvariantCulture, InvariantCultureIgnoreCase). Previously the StringComparison argument was filtered out and the native JS indexOf/lastIndexOf was used unconditionally (ordinal case-sensitive), making case-insensitive searches silently return wrong results. Fixes #2601 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
github-actions
Bot
added
automation
Automated changes
repo-assist
Created by Repo Assist
labels
Mar 27, 2026
This was referenced Mar 28, 2026
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Fixes #2601 —
String.IndexOfandString.LastIndexOfwith aStringComparisonargument silently ignored the comparison, always performing ordinal case-sensitive search.Root Cause
In
Replacements.fs, theStringComparisonenum value was explicitly filtered out of the argument list before calling native JSindexOf/lastIndexOf:This meant
"Hello".IndexOf("h", StringComparison.OrdinalIgnoreCase)returned-1instead of0.Fix
Two new functions added to
String.ts:indexOfWith(str, pattern, comparison, startIndex?)— forward searchlastIndexOfWith(str, pattern, comparison, startIndex?)— backward searchThese handle all six
StringComparisonvalues:Ordinal/InvariantCulture→ nativeindexOf/lastIndexOf(fast path)OrdinalIgnoreCase/InvariantCultureIgnoreCase→toLowerCase()loopCurrentCulture/CurrentCultureIgnoreCase→localeCompareloop with appropriatesensitivityReplacements.fsnow routes the two StringComparison patterns to these library functions, passing the comparison value as an argument rather than discarding it.Test Plan
String.IndexOf OrdinalIgnoreCase workstestString.LastIndexOf OrdinalIgnoreCase workstestStringComparison.Ordinaltests continue to passCloses #2601
🤖 Generated with Repo Assist
Note
🔒 Integrity filtering filtered 91 items
Integrity filtering activated and filtered the following items during workflow execution.
This happens when a tool call accesses a resource that does not meet the required integrity or secrecy level of the workflow.
issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)EntryPoint#2366 (list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)