-
Notifications
You must be signed in to change notification settings - Fork 324
Draft
Conversation
Collaborator
@MangelMaxime I would suggest doing separate PRs, for supporting nullable value type (i.e. System.Nullable<T>) and a different PR for nullable ref types (T | null), and keeping them as small as possible to be able to iterate on them.
Perhaps this PR can be renamed to Added support for FSharp.Linq.Nullable conversions.
MangelMaxime
commented
Jan 22, 2025
Member
Author
I would suggest doing separate PRs,
I agree this PR will need to be split because locally I have even more different fixes for others part of Fable because I am discovering some unsupported APIs.
I will make specialized PRs for the different changes.
@MangelMaxime
MangelMaxime
force-pushed
the
main
branch
from
March 20, 2026 10:42
422abf1 to
d10a2d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am starting this PR early to avoid duplicate work regarding nullable/nullness support #3887