Search code, repositories, users, issues, pull requests...

Copy link

@A-O-Emmanuel A-O-Emmanuel commented Jul 24, 2025

Implemented the Error Handling practice exercise with solution, tests, and documentation


 add error-handling exercise

010e4ec

@github-actions


 [CI] Format code

69a0b95

@github-actions

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

SleeplessByte

SleeplessByte requested changes

exercises/practice/error-handling/.meta/proof.ci.js Show resolved Hide resolved

exercises/practice/error-handling/error-handling.js Show resolved Hide resolved

exercises/practice/error-handling/error-handling.spec.js Outdated

Comment on lines 22 to 35

console.log = jest.fn();

try {

processString('');

} catch {

intentionally left empty,

I expext this call to throw,

but only care about verifying that the finally block is executed

and clean up message logged.

}

expect(console.log).toHaveBeenCalledWith('Resource cleaned up');

Copy link

Member

@SleeplessByte SleeplessByte Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work with the Browser Test Runner, but the idea is not wrong. I can help come up with an easy alternative to fix this.

Copy link

Author

@A-O-Emmanuel A-O-Emmanuel Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thank you

@SleeplessByte SleeplessByte closed this

@SleeplessByte SleeplessByte reopened this

@SleeplessByte SleeplessByte mentioned this pull request

Implement practice: error-handling #910

Open

BNAndras

BNAndras reviewed

exercises/practice/error-handling/.meta/config.json Outdated Show resolved Hide resolved

A-O-Emmanuel added 2 commits

July 29, 2025 01:27


 add github username and update proof.ci.js and error-handling.js

0c70883


 Merge branch 'implement-error-handling-exercise' of https://github.co...

42df9e1

...m/A-O-Emmanuel/javascript into implement-error-handling-exercise

@A-O-Emmanuel A-O-Emmanuel requested review from BNAndras and SleeplessByte

July 29, 2025 01:23

BNAndras

BNAndras reviewed

Jul 29, 2025

Copy link

Member

@BNAndras BNAndras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not a track maintainer here, just a friendly maintainer from elsewhere on Exercism. I made some more general comments, but whatever SleeplessBytes and Cool-Kat say is the final word. :)

exercises/practice/error-handling/error-handling.spec.js Show resolved Hide resolved

exercises/practice/error-handling/error-handling.spec.js Outdated Show resolved Hide resolved

exercises/practice/error-handling/error-handling.js Outdated Show resolved Hide resolved


 Edit introduction and update proof.ci.js, error-handling.js, and erro...

272f673

...r-handling.spec.js

@A-O-Emmanuel A-O-Emmanuel requested a review from BNAndras

August 2, 2025 23:16

SleeplessByte

SleeplessByte reviewed

Aug 19, 2025

Copy link

Member

@SleeplessByte SleeplessByte left a comment •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's there is almost done. The only issue I have is that this isn't actually handling any error!

exercises/practice/error-handling/error-handling.js Outdated Show resolved Hide resolved

exercises/practice/error-handling/error-handling.js Outdated

@@ -0,0 +1,6 @@

export const processString = (input) => {

//TODO: implement this

Copy link

Member

@SleeplessByte SleeplessByte Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all other stubs we throw new Error('...') (I don't recall the exact error message). We probably want to use that!

Copy link

Author

@A-O-Emmanuel A-O-Emmanuel Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

exercises/practice/error-handling/.meta/proof.ci.js Outdated

throw new TypeError();

}

if (input === '') {

throw new Error();

Copy link

Member

@SleeplessByte SleeplessByte Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We almost always want a message in an error. We don't need to test the exact message, but throwing an empty error is non-idiomatic.

Copy link

Author

@A-O-Emmanuel A-O-Emmanuel Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll add that

exercises/practice/error-handling/.meta/proof.ci.js Outdated

@@ -0,0 +1,9 @@

export const processString = (input) => {

if (typeof input !== 'string') {

throw new TypeError();

Copy link

Member

@SleeplessByte SleeplessByte Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We almost always want a message in an error. We don't need to test the exact message, but throwing an empty error is non-idiomatic.

@A-O-Emmanuel A-O-Emmanuel requested a review from SleeplessByte

August 26, 2025 20:05

@A-O-Emmanuel @SleeplessByte


 Update exercises/practice/error-handling/error-handling.js

8c070a5

Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>

Copy link

Author

A-O-Emmanuel commented Aug 26, 2025

Hi @SleeplessByte thanks for your review, sorry it took this long for me to reply, just to clarify, when you say "The only issue I have is that this isn't actually handling any error!" do you mean that the function should include descriptive error messages rather than handling more complex error scenarios?

@SleeplessByte

Copy link

Member

SleeplessByte commented Aug 28, 2025

@A-O-Emmanuel no worries! We are not in a hurry.

Right now, the exercise wants you to throw errors. It doesn't want you to handle the error.

Handling errors could be:

try { } catch { }

promise.catch(...)

try { } finally { }

promise.finally(...)

Copy link

Author

A-O-Emmanuel commented Aug 28, 2025

Oh, that's true, I'll just have to revert back to the way I did it before. Thanks for the clarification, I've learnt something today, "throwing errors and handling errors" are two different things, yeah, it makes sense, thank you.

A-O-Emmanuel and others added 3 commits

September 23, 2025 01:02


 edit introduction.md proof.ci.js and error-handling.js

1c87531


 resolve merge conflict: kept local code

92a7c22


 Merge branch 'exercism:main' into implement-error-handling-exercise

1e5d829

@SleeplessByte

Copy link

Member

SleeplessByte commented Oct 16, 2025

@Cool-Katt how do you feel about this?

@Cool-Katt

Copy link

Contributor

Cool-Katt commented Oct 16, 2025

I was kinda out of the loop on this one so I can review in more depth tomorrow, but preliminary assessment is that I would have liked to see a couple of more tests.

I'll probably have to get up to speed first tho, to comment more

Copy link

Author

A-O-Emmanuel commented Oct 27, 2025

Hi @Cool-Katt, okay I will add more tests, but I'll wait for your final assessment before adding more tests.

Cool-Katt

Cool-Katt reviewed

exercises/practice/error-handling/error-handling.js

export const processString = (input) => {

throw new Error('Remove this line and implement the function');

Copy link

Contributor

@Cool-Katt Cool-Katt Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way this currently is, it'll pass one of the tests by default, without the student changing anything.

Cool-Katt

Cool-Katt reviewed

exercises/practice/error-handling/error-handling.spec.js Outdated

expect(() => processString(42)).toThrow(TypeError);

});

xtest('throws Error message if string is empty', () => {

Copy link

Contributor

@Cool-Katt Cool-Katt Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if i'm vibing with this test specifically, maybe we need to add some handling for the empty string case, instead of throwing error.

In any case, more tests are needed, like for example do we want the tests to pass with any generic Error type or do we want to allow only certain types?

Cool-Katt

Cool-Katt reviewed

exercises/practice/error-handling/.docs/instructions.md Outdated

An important point of programming is how to handle errors and close resources even if errors occur.

This exercise requires you to handle various errors.

Because error handling is rather programming language specific you'll have to refer to the tests for your track to see what's exactly required.

Copy link

Contributor

@Cool-Katt Cool-Katt Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line probably needs to be removed, or at least changed because it's generic from the problem-spec repo

Cool-Katt

Cool-Katt reviewed

exercises/practice/error-handling/.docs/introduction.md Outdated

- If the input is not a string, throw a `TypeError`.

- If the input is an empty string, throw a generic `Error`.

Copy link

Contributor

@Cool-Katt Cool-Katt Oct 29, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about on empty string, instead of throwing, it returns 'INVALID' or null/undefined so we can add some handling too.

we can also explicitly forbid the generic Error type to add more complexity

@Cool-Katt

Copy link

Contributor

Cool-Katt commented Oct 29, 2025

Right, sorry folks, real life got in the way. Anyway.

The way I see it, currently its a good effort but i'd maybe like to see some more restrictions/explicit handling scenarios. It also definitely needs more tests and maybe a rewrite of the instructions.

Copy link

Author

A-O-Emmanuel commented Nov 9, 2025

Okay @Cool-Katt, thanks, just got the chance to look at your comments, been really occupied, but I should be free ending of next week to start implementing your suggestions, thank you.

A-O-Emmanuel added 5 commits

November 17, 2025 23:57


 fix test passing by default

c0be150


 Merge branch 'implement-error-handling-exercise' of https://github.co...

6978c46

...m/A-O-Emmanuel/javascript into implement-error-handling-exercise
Merge remote branch with local branch;


 add handling for empty string


 remove generic line

aaab3b1


 edit instructions.md, add more tests

dca8391

@A-O-Emmanuel A-O-Emmanuel requested a review from Cool-Katt

December 28, 2025 00:44