In `@pnpm-workspace.yaml`:
- Around line 14-15: The react version is pinned to "19.1.0" while other
packages use caret ranges; either make the pin intentional or change to a caret
range—update the react entry (and by extension react-dom which references it) in
pnpm-workspace.yaml to use a caret range (e.g., "^19.1.0") if you want normal
semver updates, or add a short comment/docstring indicating that keeping react
at the exact "19.1.0" is deliberate to prevent accidental upgrades.
In `@server/api/activity.ts`:
- Around line 326-370: The map callback for the array mapping (the .map(...)
that checks item.type === "panda" and "repay") can return undefined for other
item types; replace this .map with .flatMap and ensure the callback returns an
array: return [pandaObject] for "panda", [repayObject] for "repay", and [] for
all other cases so no implicit undefineds remain; keep the existing logic
building the panda object (including the installments accumulator and
Map.values().toArray()) and the repay object (positionAmount/amount/discount)
but wrap each in an array when returning from the callback.
- Around line 361-367: The repay branch returns a discount computed as
((item.positionAmount - item.amount) / item.positionAmount) * 100 which can
divide by zero; update the repay case in the activity mapping (the branch
checking item.type === "repay") to guard against positionAmount === 0 by
computing discount only when positionAmount is nonzero (e.g., set discount to 0
or null when item.positionAmount === 0) and otherwise calculate the percentage
as before; ensure you reference item.positionAmount and item.amount in the
guarded expression so no division by zero occurs.
- Around line 69-72: The request schema allows any string for the "maturity"
field which later is passed to BigInt() and Number(), so validate it at the
schema level: update the optional(object(...)) schema that defines maturity to
use a numeric-string validator (e.g., replace optional(string()) with a
regex/number-string validator) so only decimal-integer strings (or an accepted
numeric format) are allowed; also add the regex import to the valibot imports
(per comment) and keep the field name "maturity" and surrounding schema
structure intact so BigInt(maturity) and Number(maturity) calls downstream won't
throw on invalid input.
- Around line 334-343: The code uses findIndex to locate an installment (in
server/api/activity.ts) and then builds progress and accesses installments[n]
without checking for a not-found (-1) result; update the block that computes n
(the findIndex on operation.borrow.installments) to detect n === -1 and skip
processing or continue (i.e., do not add a progress entry or modify the
accumulator) when no matching maturity is found, ensuring you do not compute
progress = `${n+1}/${...}` or access installments[n] when n is -1; apply this
guard around the logic that creates/updates status and amount so only valid
installment matches are aggregated.
- Around line 272-315: The map callbacks inside the response construction (the
cardPurchases.flatMap(... transactions.map(...)) branch and the [...deposits,
...repays, ...withdraws].map(...) branch) sometimes fall through to
captureException and implicitly return undefined, triggering the linter; change
those inner .map usages to .flatMap and, where you currently call
captureException, return an empty array ([]) instead of falling through so the
flatMap removes the bad item inline; keep the outer cardPurchases.flatMap and
replace the deposits/repays/withdraws .map with .flatMap as well, using the same
pattern (return the mapped object on success or [] after captureException) so
the subsequent filter step becomes unnecessary.
In `@server/test/api/activity.test.ts`:
- Around line 213-235: The test duplicates maturity extraction and risks
producing "undefined" by using String(withBorrow && withBorrow.borrow.maturity);
change to assert and use a non-null assertion when reading the maturity (e.g.,
use withBorrow!.borrow.maturity) or extract a small helper
(getBorrowMaturity(from activity) or a local const getMaturity) to compute
maturity once, then pass String(getMaturity(withBorrow!)) into the request;
update the occurrences around the withBorrow variable and the maturity const in
the tests (the "filters by maturity" and the similar "returns statement pdf"
block) so you no longer use the && pattern and avoid duplicated extraction
logic.
In `@server/tsconfig.json`:
- Line 3: The tsconfig currently sets "jsx": "react" but the "include" globs
only match *.ts so .tsx files like server/utils/Statement.tsx are excluded;
update the tsconfig "include" array to add matching .tsx patterns (e.g., add
"*.tsx" or directory-specific "*.tsx" entries for any folders that contain React
components) so the TypeScript compiler picks up .tsx files, ensuring the "jsx"
option is effective and future .tsx files are compiled.
In `@server/utils/Statement.tsx`:
- Around line 79-91: The default-exported React component Statement is currently
defined below supporting details (like styles); move the Statement
declaration/export so the default export is at the top of the file above any
helpers/styles. Specifically, place the Statement function (the component that
accepts props { data, lastFour, maturity }) and its export before the styles
object and any helper functions, and apply the same change for the other default
export referenced around line ~199 so all default exports appear at the top with
supporting details below.
- Around line 94-112: Extract the duplicated inline union member types into
named types (e.g., RepaymentItem and PurchaseItem) and use those types both in
the component props union and in the type guard predicates used for repayments
and purchases; update the predicates that currently assert "positionAmount" in
item and "description" in item to be typed as (item): item is RepaymentItem and
(item): item is PurchaseItem respectively, and replace the repeated inline shape
definitions wherever they appear (including the props union and the
repayments/purchases filters) to reference the new named types.
- Around line 152-156: The discount chip currently renders even when
item.discount is 0; update the JSX that renders the <View
style={styles.discountChip}> / <Text style={styles.discountText}> so it is
conditionally rendered only when item.discount is greater than 0 (e.g., guard
with item.discount > 0 or Boolean(item.discount) around that block). Locate the
rendering block in Statement.tsx (the View with flexDirection row that contains
styles.discountChip and styles.discountText) and wrap it in a conditional check
to prevent "0.00% discount applied" from showing.
In `@src/utils/server.ts`:
- Around line 240-241: The current code calls parseResponse(response) and then
converts any non-array result to [] which can silently swallow errors and bypass
the file's usual APIError handling; update the flow to first check response.ok
and, if false, parse the error body and throw an APIError (preserving
status/message), otherwise call parseResponse(response) and return the parsed
value only if Array.isArray(parsed) (or throw/convert explicitly), referencing
the existing APIError class, the parseResponse function, and the response.ok
boolean so callers receive consistent structured errors instead of opaque or
empty arrays.