Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Comments

feat: migrate from ethers.js to viem#117

Open
nikhilkumar1612 wants to merge 4 commits intoetherspot:master from
nikhilkumar1612:issue-113
Open

feat: migrate from ethers.js to viem #117
nikhilkumar1612 wants to merge 4 commits intoetherspot:master from
nikhilkumar1612:issue-113

Conversation

@nikhilkumar1612
Copy link
Member

@nikhilkumar1612 nikhilkumar1612 commented Jul 23, 2024

Description

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Copy link
Member

Thanks for submitting the PR. Pls can you let us know how you tested this?

Copy link
Member Author

Thanks for submitting the PR. Pls can you let us know how you tested this?

Hey i have tested my changes individully, but e2e testing is not done. Please provide me api details and sample env.

if(log) log.info('setting maxFeePerGas and maxPriorityFeePerGas as received')
const maxFeePerGas = ethers.utils.parseUnits(response.result.suggestBaseFee, 'gwei')
const fastGasPrice = ethers.utils.parseUnits(response.result.FastGasPrice, 'gwei')
const maxFeePerGas = parseUnits(response.result.suggestBaseFee, 9);
Copy link
Contributor

@kanthgithub kanthgithub Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhilkumar1612 create a constant value for gwei and use it allover where parseUnits of viem is called for GWEI conversion

Copy link
Member Author

@nikhilkumar1612 nikhilkumar1612 Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhilkumar1612 create a constant value for gwei and use it allover where parseUnits of viem is called for GWEI conversion

sure 👍 @kanthgithub

Copy link
Contributor

@nikhilkumar1612 please use the latest version of viem. seems the sendTransaction signature changed in latest version
2.17.0 is latest release

Copy link
Member Author

@nikhilkumar1612 please use the latest version of viem. seems the sendTransaction signature changed in latest version 2.17.0 is latest release

hey @kanthgithub i can see 2.17.10 is the latest version, please let me know if i have to use 2.17.0 or 2.17.10 ?

Copy link
Member Author

hey @kanthgithub are there any further changes that i have to make ?

also please provide a confirm on the version of viem.
md-rifatkhan reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kanthgithub kanthgithub kanthgithub left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /