Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(tests): Fix periman and add missing diagrams #12126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucasssvaz wants to merge 2 commits into espressif:master
base: master
Choose a base branch
Loading
from lucasssvaz:fix/periman

Conversation

@lucasssvaz
Copy link
Member

@lucasssvaz lucasssvaz commented Dec 11, 2025

Description of Change

This pull request introduces significant improvements to peripheral resource management and validation testing in the ESP32 codebase. The main focus is on ensuring that both automatic and manual deinitialization (deinit) of peripherals is robustly tested and that resource cleanup, especially for DMA buffers and ADC drivers, is handled correctly. The changes also enhance test coverage for manual deinit paths and update test infrastructure to reflect these improvements.

Peripheral Resource Management Improvements:

  • Added cache line alignment for DMA buffers and conversion frame sizes on ESP32-P4 targets to ensure compatibility with DMA and cache requirements, using heap_caps_aligned_alloc for buffer allocation. [1] [2]
  • Improved cleanup logic in ADC continuous mode: added guards against double cleanup, ensured calibration handles are properly released, and clarified responsibilities between the ADC driver and the peripheral manager. [1] [2]
  • Ensured all dynamically allocated DMA buffers are freed after use or on error, preventing memory leaks in ADC continuous read routines. [1] [2]
  • Updated analogContinuousDeinit to always clear used pins through the peripheral manager and to free the result buffer, improving robustness of deinitialization.

Validation Test Enhancements:

  • Extended validation tests (periman.ino) to include explicit manual deinit tests for SigmaDelta, LEDC, RMT, I2S, I2C, SPI, and ADC Continuous peripherals. Each test now verifies that Serial1 can be restored after manual deinit, ensuring that the peripheral manager and driver cleanup are reliable. [1] [2] [3] [4] [5] [6] [7]
  • Refactored test setup and teardown to better distinguish between auto-detach (via pinMode) and manual deinit test paths. [1] [2]

Test Infrastructure Updates:

  • Updated the Python validation script (test_periman.py) to dynamically track which peripherals have manual deinit tests, parse and match test output accordingly, and provide clearer logging and error messages. This ensures all expected tests are executed and validated. [1] [2]
  • Minor cleanup in test configuration files (ci.yml) for platform and target definitions. [1] [2]

Miscellaneous:

  • Added a Wokwi diagram for the ESP32-H2 SD card test setup.

These changes collectively improve the reliability and maintainability of peripheral resource management, and provide stronger guarantees through comprehensive automated testing.


References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]

Test Scenarios

Tested locally

Copy link
Contributor

github-actions bot commented Dec 11, 2025
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0a961e0

@lucasssvaz lucasssvaz added Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. CI Failure Expected For PRs where CI failure is expected labels Dec 11, 2025
Copy link
Contributor

github-actions bot commented Dec 11, 2025
edited
Loading

Test Results

90 files 90 suites 30m 8s ⏱️
66 tests 56 ✅ 0 💤 10 ❌
675 runs 655 ✅ 0 💤 20 ❌

For more details on these failures, see this check.

Results for commit 0a961e0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 11, 2025
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4💚 -3520💚 -0.110.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2💚 -2800💚 -0.100.00000.000.00
ESP32C3💚 -3600💚 -0.120.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2💚 -3140💚 -0.110.00000.000.00
ESP32💚 -280⚠️ +4💚 -0.090.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ArduinoOTA/examples/BasicOTA00000000----00
libraries/AsyncUDP/examples/AsyncUDPClient00000000----00
libraries/AsyncUDP/examples/AsyncUDPMulticastServer00--0000----00
libraries/AsyncUDP/examples/AsyncUDPServer00--0000----00
libraries/BLE/examples/Beacon_Scanner00----00--0000
libraries/BLE/examples/Client00----00--0000
libraries/BLE/examples/Client_Server00----00--0000
libraries/BLE/examples/Client_multiconnect00----00--0000
libraries/BLE/examples/Client_secure_static_passkey00----00--0000
libraries/BLE/examples/EddystoneTLM_Beacon00----00--0000
libraries/BLE/examples/EddystoneURL_Beacon00----00--0000
libraries/BLE/examples/Notify00----00--0000
libraries/BLE/examples/Scan00----00--0000
libraries/BLE/examples/Server00----00--0000
libraries/BLE/examples/Server_multiconnect00----00--0000
libraries/BLE/examples/Server_secure_static_passkey00----00--0000
libraries/BLE/examples/UART00----00--0000
libraries/BLE/examples/Write00----00--0000
libraries/BLE/examples/iBeacon00----00--0000
libraries/DNSServer/examples/CaptivePortal00--0000----00
libraries/EEPROM/examples/eeprom_class00--0000--0000
libraries/EEPROM/examples/eeprom_extra00--0000--0000
libraries/EEPROM/examples/eeprom_write00--0000--0000
libraries/ESP32/examples/AnalogOut/LEDCFade00--0000--0000
libraries/ESP32/examples/AnalogOut/LEDCGammaFade00--------00--
libraries/ESP32/examples/AnalogOut/LEDCSingleChannel00--0000--0000
libraries/ESP32/examples/AnalogOut/LEDCSoftwareFade00--0000--0000
libraries/ESP32/examples/AnalogOut/SigmaDelta00--0000--0000
libraries/ESP32/examples/AnalogOut/ledcFrequency00--0000--0000
libraries/ESP32/examples/AnalogOut/ledcWrite_RGB00--0000--0000
libraries/ESP32/examples/AnalogRead00--0000--00⚠️ +40
libraries/ESP32/examples/AnalogReadContinuous💚 -3520--💚 -2800💚 -3600--💚 -3140💚 -2800
libraries/ESP32/examples/ArduinoStackSize00--0000--0000
libraries/ESP32/examples/ArduinoWaitTimeBeforeStartingSketch00--0000--0000
libraries/ESP32/examples/CI/CIBoardsTest00--0000--0000
libraries/ESP32/examples/ChipID/GetChipID00--0000--0000
libraries/ESP32/examples/DeepSleep/TimerWakeUp00--0000----00
libraries/ESP32/examples/DeepSleep/TouchWakeUp00--00------00
libraries/ESP32/examples/FreeRTOS/BasicMultiThreading00--0000--0000
libraries/ESP32/examples/FreeRTOS/Mutex00--0000--0000
libraries/ESP32/examples/FreeRTOS/Queue00--0000--0000
libraries/ESP32/examples/FreeRTOS/Semaphore00--0000--0000
libraries/ESP32/examples/GPIO/BlinkRGB00--0000--0000
libraries/ESP32/examples/GPIO/FunctionalInterrupt00--0000--0000
libraries/ESP32/examples/GPIO/FunctionalInterruptLambda00--0000--0000
libraries/ESP32/examples/GPIO/FunctionalInterruptStruct00--0000--0000
libraries/ESP32/examples/GPIO/GPIOInterrupt00--0000--0000
libraries/ESP32/examples/HWCDC_Events00----00--00--
libraries/ESP32/examples/MacAddress/GetMacAddress00--0000--0000
libraries/ESP32/examples/RMT/Legacy_RMT_Driver_Compatible00--0000--0000
libraries/ESP32/examples/RMT/RMTCallback00--0000--0000
libraries/ESP32/examples/RMT/RMTLoopback00--0000--0000
libraries/ESP32/examples/RMT/RMTReadXJT00--0000--0000
libraries/ESP32/examples/RMT/RMTWrite_RGB_LED00--0000--0000
libraries/ESP32/examples/RMT/RMT_CPUFreq_Test00--0000--0000
libraries/ESP32/examples/RMT/RMT_EndOfTransmissionState00--0000--0000
libraries/ESP32/examples/RMT/RMT_LED_Blink00--0000--0000
libraries/ESP32/examples/ResetReason/ResetReason00--0000--0000
libraries/ESP32/examples/ResetReason/ResetReason200--0000--0000
libraries/ESP32/examples/Serial/BaudRateDetect_Demo00--0000--0000
libraries/ESP32/examples/Serial/OnReceiveError_BREAK_Demo00--0000--0000
libraries/ESP32/examples/Serial/OnReceive_Demo00--0000--0000
libraries/ESP32/examples/Serial/RS485_Echo_Demo00--0000--0000
libraries/ESP32/examples/Serial/RxFIFOFull_Demo00--0000--0000
libraries/ESP32/examples/Serial/RxTimeout_Demo00--0000--0000
libraries/ESP32/examples/Serial/Serial_All_CPU_Freqs00--0000--0000
libraries/ESP32/examples/Serial/Serial_STD_Func_OnReceive00--0000--0000
libraries/ESP32/examples/Serial/onReceiveExample00--0000--0000
libraries/ESP32/examples/TWAI/TWAIreceive00--0000--0000
libraries/ESP32/examples/TWAI/TWAItransmit00--0000--0000
libraries/ESP32/examples/Template/ExampleTemplate00--0000--0000
libraries/ESP32/examples/Time/SimpleTime00--0000----00
libraries/ESP32/examples/Timer/RepeatTimer00--0000--0000
libraries/ESP32/examples/Timer/WatchdogTimer00--0000--0000
libraries/ESP32/examples/Touch/TouchButton00--00------00
libraries/ESP32/examples/Touch/TouchInterrupt00--00------00
libraries/ESP32/examples/Touch/TouchRead00--00------00
libraries/ESP_HostedOTA/examples/ESP_HostedOTA00------------
libraries/ESP_I2S/examples/ES8388_loopback00--0000--0000
libraries/ESP_I2S/examples/Record_to_WAV00----------00
libraries/ESP_I2S/examples/Simple_tone00--0000--0000
libraries/ESP_SR/examples/Basic00------------
libraries/ESPmDNS/examples/mDNS-SD_Extended00--0000----00
libraries/ESPmDNS/examples/mDNS_Web_Server00--0000----00
libraries/Ethernet/examples/ETH_TLK11000----------00
libraries/Ethernet/examples/ETH_W5500_Arduino_SPI00--0000--0000
libraries/Ethernet/examples/ETH_W5500_IDF_SPI00--0000--0000
libraries/Ethernet/examples/ETH_WIFI_BRIDGE00--0000----00
libraries/FFat/examples/FFat_Test00--0000--0000
libraries/FFat/examples/FFat_time00--0000----00
libraries/HTTPClient/examples/Authorization00--0000----00
libraries/HTTPClient/examples/BasicHttpClient00--0000----00
libraries/HTTPClient/examples/BasicHttpsClient00--0000----00
libraries/HTTPClient/examples/CustomHeaders00--0000----00
libraries/HTTPClient/examples/ReuseConnection00--0000----00
libraries/HTTPClient/examples/StreamHttpClient00--0000----00
libraries/HTTPUpdate/examples/httpUpdate00--0000----00
libraries/HTTPUpdate/examples/httpUpdateSPIFFS00--0000----00
libraries/HTTPUpdate/examples/httpUpdateSecure00--0000----00
libraries/HTTPUpdateServer/examples/WebUpdater00--0000----00
libraries/Hash/examples/HEX00--0000--0000
libraries/Hash/examples/MD500--0000--0000
libraries/Hash/examples/PBKDF2_HMAC00--0000--0000
libraries/Hash/examples/SHA100--0000--0000
libraries/Hash/examples/SHA200--0000--0000
libraries/Hash/examples/SHA300--0000--0000
libraries/Hash/examples/SHA3Stream00--0000--0000
libraries/LittleFS/examples/LITTLEFS_test00--0000--0000
libraries/LittleFS/examples/LITTLEFS_time00--0000----00
libraries/NetBIOS/examples/ESP_NBNST00--0000----00
libraries/NetworkClientSecure/examples/WiFiClientInsecure00--0000----00
libraries/NetworkClientSecure/examples/WiFiClientPSK00--0000----00
libraries/NetworkClientSecure/examples/WiFiClientSecure00--0000----00
libraries/NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade00--0000----00
libraries/NetworkClientSecure/examples/WiFiClientShowPeerCredentials00--0000----00
libraries/NetworkClientSecure/examples/WiFiClientTrustOnFirstUse00--0000----00
libraries/PPP/examples/PPP_Basic00--0000--0000
libraries/PPP/examples/PPP_WIFI_BRIDGE00--0000----00
libraries/Preferences/examples/Prefs2Struct00--0000--0000
libraries/Preferences/examples/StartCounter00--0000--0000
libraries/SD/examples/SD_Test00--0000--0000
libraries/SD/examples/SD_time00--0000----00
libraries/SD_MMC/examples/SD2USBMSC00------------
libraries/SD_MMC/examples/SDMMC_Test00----------00
libraries/SD_MMC/examples/SDMMC_time00----------00
libraries/SPI/examples/SPI_Multiple_Buses00--0000--0000
libraries/SPIFFS/examples/SPIFFS_Test00--0000--0000
libraries/SPIFFS/examples/SPIFFS_time00--0000----00
libraries/TFLiteMicro/examples/hello_world00--0000--0000
libraries/Ticker/examples/Blinker00--0000--0000
libraries/Ticker/examples/TickerBasic00--0000--0000
libraries/Ticker/examples/TickerParameter00--0000--0000
libraries/USB/examples/CompositeDevice00--00--------
libraries/USB/examples/ConsumerControl00--00--------
libraries/USB/examples/CustomHIDDevice00--00--------
libraries/USB/examples/FirmwareMSC00--00--------
libraries/USB/examples/Gamepad00--00--------
libraries/USB/examples/HIDVendor00--00--------
libraries/USB/examples/Keyboard/KeyboardLogout00--00--------
libraries/USB/examples/Keyboard/KeyboardMessage00--00--------
libraries/USB/examples/Keyboard/KeyboardReprogram00--00--------
libraries/USB/examples/Keyboard/KeyboardSerial00--00--------
libraries/USB/examples/KeyboardAndMouseControl00--00--------
libraries/USB/examples/MIDI/MidiController00--00--------
libraries/USB/examples/MIDI/MidiInterface00--00--------
libraries/USB/examples/MIDI/MidiMusicBox00--00--------
libraries/USB/examples/MIDI/ReceiveMidi00--00--------
libraries/USB/examples/Mouse/ButtonMouseControl00--00--------
libraries/USB/examples/SystemControl00--00--------
libraries/USB/examples/USBMSC00--00--------
libraries/USB/examples/USBSerial00--00--------
libraries/USB/examples/USBVendor00--00--------
libraries/Update/examples/AWS_S3_OTA_Update00--0000----00
libraries/Update/examples/HTTPS_OTA_Update00--0000----00
libraries/Update/examples/HTTP_Client_AES_OTA_Update00--0000----00
libraries/Update/examples/HTTP_Server_AES_OTA_Update00--0000----00
libraries/Update/examples/OTAWebUpdater00--0000----00
libraries/Update/examples/SD_Update00--0000--0000
libraries/WebServer/examples/AdvancedWebServer00--0000----00
libraries/WebServer/examples/ChunkWriting00--0000----00
libraries/WebServer/examples/FSBrowser00--0000----00
libraries/WebServer/examples/Filters00--0000----00
libraries/WebServer/examples/HelloServer00--0000----00
libraries/WebServer/examples/HttpAdvancedAuth00--0000----00
libraries/WebServer/examples/HttpAuthCallback00--0000----00
libraries/WebServer/examples/HttpAuthCallbackInline00--0000----00
libraries/WebServer/examples/HttpBasicAuth00--0000----00
libraries/WebServer/examples/HttpBasicAuthSHA100--0000----00
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken00--0000----00
libraries/WebServer/examples/MultiHomedServers00--0000----00
libraries/WebServer/examples/PathArgServer00--0000----00
libraries/WebServer/examples/SDWebServer00--0000----00
libraries/WebServer/examples/SimpleAuthentification00--0000----00
libraries/WebServer/examples/UploadHugeFile00--0000----00
libraries/WebServer/examples/WebServer00--0000----00
libraries/WebServer/examples/WebUpdate00--0000----00
libraries/WiFi/examples/FTM/FTM_Initiator00--0000----00
libraries/WiFi/examples/FTM/FTM_Responder00--0000----00
libraries/WiFi/examples/SimpleWiFiServer00--0000----00
libraries/WiFi/examples/WiFiAccessPoint00--0000----00
libraries/WiFi/examples/WiFiClient00--0000----00
libraries/WiFi/examples/WiFiClientBasic00--0000----00
libraries/WiFi/examples/WiFiClientConnect00--0000----00
libraries/WiFi/examples/WiFiClientEvents00--0000----00
libraries/WiFi/examples/WiFiClientStaticIP00--0000----00
libraries/WiFi/examples/WiFiExtender00--0000----00
libraries/WiFi/examples/WiFiIPv600--0000----00
libraries/WiFi/examples/WiFiMulti00--0000----00
libraries/WiFi/examples/WiFiMultiAdvanced00--0000----00
libraries/WiFi/examples/WiFiScan00--0000----00
libraries/WiFi/examples/WiFiScanAsync00--0000----00
libraries/WiFi/examples/WiFiScanDualAntenna00--0000----00
libraries/WiFi/examples/WiFiScanTime00--0000----00
libraries/WiFi/examples/WiFiTelnetToSerial00--0000----00
libraries/WiFi/examples/WiFiUDPClient00--0000----00
libraries/Wire/examples/WireMaster00--0000--0000
libraries/Wire/examples/WireScan00--0000--0000
libraries/Wire/examples/WireSlave00--0000--0000
libraries/Wire/examples/WireSlaveFunctionalCallback00--0000--0000
tests/validation/periman--------------
libraries/ESP32/examples/Camera/CameraWebServer----00------00
ESP32/examples/Camera/CameraWebServer (2)----00------00
libraries/ESP32/examples/DeepSleep/ExternalWakeUp----00------00
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master----0000----00
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave----0000----00
libraries/ESP_NOW/examples/ESP_NOW_Network----0000----00
libraries/ESP_NOW/examples/ESP_NOW_Serial----0000----00
libraries/HTTPClient/examples/HTTPClientEnterprise----0000----00
libraries/Insights/examples/DiagnosticsSmokeTest----0000----00
libraries/Insights/examples/MinimalDiagnostics----0000----00
libraries/Matter/examples/MatterColorLight----0000--0000
libraries/Matter/examples/MatterCommissionTest----0000--0000
libraries/Matter/examples/MatterComposedLights----0000--0000
libraries/Matter/examples/MatterContactSensor----0000--0000
libraries/Matter/examples/MatterDimmableLight----0000--0000
libraries/Matter/examples/MatterDimmablePlugin----0000--0000
libraries/Matter/examples/MatterEnhancedColorLight----0000--0000
libraries/Matter/examples/MatterEvents----0000--0000
libraries/Matter/examples/MatterFan----0000--0000
libraries/Matter/examples/MatterHumiditySensor----0000--0000
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs----0000--0000
libraries/Matter/examples/MatterMinimum----0000--0000
libraries/Matter/examples/MatterOccupancySensor----0000--0000
libraries/Matter/examples/MatterOnIdentify----0000--0000
libraries/Matter/examples/MatterOnOffLight----0000--0000
libraries/Matter/examples/MatterOnOffPlugin----0000--0000
libraries/Matter/examples/MatterPressureSensor----0000--0000
libraries/Matter/examples/MatterRainSensor----0000--0000
libraries/Matter/examples/MatterSimpleBlinds----0000--0000
libraries/Matter/examples/MatterSmartButton----0000--0000
libraries/Matter/examples/MatterStatus----0000--0000
libraries/Matter/examples/MatterTemperatureControlledCabinet----0000--0000
libraries/Matter/examples/MatterTemperatureControlledCabinetLevels----0000--0000
libraries/Matter/examples/MatterTemperatureLight----0000--0000
libraries/Matter/examples/MatterTemperatureSensor----0000--0000
libraries/Matter/examples/MatterThermostat----0000--0000
libraries/Matter/examples/MatterWaterFreezeDetector----0000--0000
libraries/Matter/examples/MatterWaterLeakDetector----0000--0000
libraries/Matter/examples/MatterWindowCovering----0000--0000
libraries/NetworkClientSecure/examples/WiFiClientSecureEnterprise----0000----00
libraries/RainMaker/examples/RMakerCustom----0000------
libraries/RainMaker/examples/RMakerCustomAirCooler----0000------
libraries/RainMaker/examples/RMakerSonoffDualR3----0000------
libraries/RainMaker/examples/RMakerSwitch----0000------
libraries/WebServer/examples/Middleware----0000----00
libraries/WiFi/examples/WPS----0000----00
libraries/WiFi/examples/WiFiClientEnterprise----0000----00
libraries/WiFi/examples/WiFiSmartConfig----0000----00
libraries/WiFiProv/examples/WiFiProv----0000----00
libraries/Zigbee/examples/Zigbee_Analog_Input_Output----0000--0000
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch----0000--0000
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor----0000--00⚠️ +40
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor_MultiPhase----0000--00⚠️ +40
libraries/Zigbee/examples/Zigbee_Fan_Control----0000--0000
libraries/Zigbee/examples/Zigbee_Gateway----0000----00
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output----0000--0000
libraries/Zigbee/examples/Zigbee_On_Off_MultiSwitch----0000--0000
libraries/Zigbee/examples/Zigbee_On_Off_Switch----0000--0000
libraries/Zigbee/examples/Zigbee_Power_Outlet----0000--0000
libraries/Zigbee/examples/Zigbee_Range_Extender----0000--0000
libraries/Zigbee/examples/Zigbee_Thermostat----0000--0000
libraries/BLE/examples/Server_secure_authorization------00--00--
libraries/WiFi/examples/WiFiBlueToothSwitch------00----00
libraries/OpenThread/examples/CLI/COAP/coap_lamp----------00--
libraries/OpenThread/examples/CLI/COAP/coap_switch----------00--
libraries/OpenThread/examples/CLI/SimpleCLI----------00--
libraries/OpenThread/examples/CLI/SimpleNode----------00--
libraries/OpenThread/examples/CLI/SimpleThreadNetwork/ExtendedRouterNode----------00--
libraries/OpenThread/examples/CLI/SimpleThreadNetwork/LeaderNode----------00--
libraries/OpenThread/examples/CLI/SimpleThreadNetwork/RouterNode----------00--
libraries/OpenThread/examples/CLI/ThreadScan----------00--
libraries/OpenThread/examples/CLI/onReceive----------00--
libraries/OpenThread/examples/Native/SimpleThreadNetwork/LeaderNode----------00--
libraries/OpenThread/examples/Native/SimpleThreadNetwork/RouterNode----------00--
libraries/Zigbee/examples/Zigbee_Binary_Input_Output----------00--
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor----------00--
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light----------00--
libraries/Zigbee/examples/Zigbee_Contact_Switch----------00--
libraries/Zigbee/examples/Zigbee_Dimmable_Light----------00--
libraries/Zigbee/examples/Zigbee_Electrical_DC_Sensor----------00--
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor----------00--
libraries/Zigbee/examples/Zigbee_OTA_Client----------00--
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor----------00--
libraries/Zigbee/examples/Zigbee_On_Off_Light----------00--
libraries/Zigbee/examples/Zigbee_PM25_Sensor----------00--
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor----------00--
libraries/Zigbee/examples/Zigbee_Scan_Networks----------00--
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy----------00--
libraries/Zigbee/examples/Zigbee_Temperature_Sensor----------00--
libraries/Zigbee/examples/Zigbee_Vibration_Sensor----------00--
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor----------00--
libraries/Zigbee/examples/Zigbee_Window_Covering----------00--
libraries/BluetoothSerial/examples/DiscoverConnect------------00
libraries/BluetoothSerial/examples/GetLocalMAC------------00
libraries/BluetoothSerial/examples/SerialToSerialBT------------00
libraries/BluetoothSerial/examples/SerialToSerialBTM------------00
libraries/BluetoothSerial/examples/SerialToSerialBT_Legacy------------00
libraries/BluetoothSerial/examples/SerialToSerialBT_SSP------------00
libraries/BluetoothSerial/examples/bt_classic_device_discovery------------00
libraries/BluetoothSerial/examples/bt_remove_paired_devices------------00
libraries/ESP32/examples/DeepSleep/SmoothBlink_ULP_Code------------00
libraries/Ethernet/examples/ETH_LAN8720------------00
libraries/SimpleBLE/examples/SimpleBleDevice------------00

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances peripheral resource management testing and fixes issues in ADC continuous mode for ESP32 targets. The changes add comprehensive manual deinitialization tests for various peripherals and improve DMA buffer handling for cache-aligned targets like ESP32-P4.

  • Added manual deinit test paths for SigmaDelta, LEDC, RMT, I2S, I2C, SPI, and ADC_Continuous peripherals
  • Improved ADC continuous mode with cache-aligned DMA buffer allocation and proper memory cleanup
  • Added Wokwi simulation diagrams for ESP32-P4 and ESP32-H2 SD card test setups

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/validation/sdcard/diagram.esp32p4.json New Wokwi diagram for ESP32-P4 SD card test configuration with two SD cards
tests/validation/sdcard/diagram.esp32h2.json New Wokwi diagram for ESP32-H2 SD card test configuration
tests/validation/sdcard/ci.yml CI configuration for SD card tests (disabled for hardware and QEMU)
tests/validation/periman/test_periman.py Enhanced Python test script to track and validate both auto-detach and manual deinit tests
tests/validation/periman/periman.ino Added manual deinit test cases for 7 peripherals to verify proper resource cleanup
tests/validation/periman/ci.yml Removed ESP32-P4 target exclusion from periman tests
cores/esp32/esp32-hal-adc.c Improved ADC continuous mode with cache-aligned DMA buffers, guard against double-cleanup, and proper memory management

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Labels

CI Failure Expected For PRs where CI failure is expected Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /