fix(esp32): Compiler warning - loop variable `a` shadows previous instance of `a` in function `i2c_slave_gpio_mode` #11828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

martinbudden wants to merge 1 commit into espressif:master

from martinbudden:fix_shadow_warning_loop

Open

fix(esp32): Compiler warning - loop variable `a` shadows previous instance of `a` in function `i2c_slave_gpio_mode` #11828

martinbudden wants to merge 1 commit into espressif:master from martinbudden:fix_shadow_warning_loop

+1 −1

Conversation

martinbudden

Copy link

@martinbudden martinbudden commented Sep 13, 2025

In function i2c_slave_gpio_mode an inner loop variable a shadows an outer loop variable a.

This causes the warning:
warning: declaration of 'a' shadows a previous local [-Wshadow]
when compiled with option-Wshadow.

Description of Change

Renamed variable a in inner loop to b.

Test Scenarios

Code compiles without warning when change made.

Related links

None

@martinbudden


 Fix shadow warning - loop variable a shadows previous instance of a.

02469d4

@martinbudden martinbudden requested a review from a team as a code owner

September 13, 2025 15:04

@CLAassistant

Copy link

CLAassistant commented Sep 13, 2025 •

edited

Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Sep 13, 2025 •

edited

Loading

Warnings

⚠️

Some issues found for the commit messages in this PR:

the commit message "Fix shadow warning - loop variable a shadows previous instance of a.":
- summary should not end with a period (full stop)
- summary looks empty
- type/action looks empty

Please fix these commit messages - here are some basic tips:

follow Conventional Commits style
correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello martinbudden, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 02469d4

@martinbudden martinbudden changed the title ~~(削除) Fix shadow warning - loop variable a shadows previous instance of a in function i2c_slave_gpio_mode (削除ここまで)~~ (追記) fix(esp32): Compiler warning - loop variable a shadows previous instance of a in function i2c_slave_gpio_mode (追記ここまで)

Sep 13, 2025

@martinbudden martinbudden changed the title ~~(削除) fix(esp32): Compiler warning - loop variable a shadows previous instance of a in function i2c_slave_gpio_mode (削除ここまで)~~ (追記) fix(esp32): Compiler warning - loop variable a shadows previous instance of a in function i2c_slave_gpio_mode (追記ここまで)

Sep 13, 2025

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Sep 13, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32C5	0	0	0.00	0.00	0	0	0.00	0.00
ESP32P4	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S2	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C6	0	0	0.00	0.00	0	0	0.00	0.00
ESP32H2	0	0	0.00	0.00	0	0	0.00	0.00
ESP32	0	0	0.00	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32C5		ESP32P4		ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/ESP32/examples/CI/CIBoardsTest	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0
libraries/ESP_I2S/examples/ES8388_loopback	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0
libraries/HTTPClient/examples/HTTPClientEnterprise	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/NetworkClientSecure/examples/WiFiClientSecureEnterprise	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Wire/examples/WireMaster	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Wire/examples/WireScan	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Wire/examples/WireSlave	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Wire/examples/WireSlaveFunctionalCallback	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0